Bug 126763 – Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Push down the first agent. The simple InspectorAgent agent!

Also, hook up the pipes and create a JSGlobalObjectInspectorController! You can now actually remotely inspect a JSGlobalObject and bits get sent back and forth! But, nothing exciting happens right now and the frontend would immediately throw an exception. Not concerned with that just yet until we get to RuntimeAgent.

Also, make WebCore use the Inspector::InspectorAgent.

[Radar WebKit Bug Importer]

<rdar://problem/15793721>

[Joseph Pecoraro]

Adding JSC engineers because the patch will make use of APIShims.

[Joseph Pecoraro]

Created attachment 220869 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 220869 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.cpp', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/inspector/CommandLineAPIHost.cpp', u'Source/WebCore/inspector/CommandLineAPIHost.h', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InstrumentingAgents.h', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageConsoleAgent.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 5 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 220869 [details]
[PATCH] Proposed Fix

Attachment 220869 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6413797338120192

[EFL EWS Bot]

Comment on attachment 220869 [details]
[PATCH] Proposed Fix

Attachment 220869 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6209058797256704

[Joseph Pecoraro]

Created attachment 220873 [details]
[PATCH] Proposed Fix

[EFL EWS Bot]

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6026769245143040

[Timothy Hatcher]

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220873&action=review

Nice and clean.

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014!

[Timothy Hatcher]

I'll let the JSC guys comment on APIShims if needed. r+ for everything else.

[EFL EWS Bot]

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5933584024076288

[Joseph Pecoraro]

Created attachment 220883 [details]
[PATCH] For Bots 1

I'll try including the Subdirectory in the forwarding path. So:
- Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h
+ Source/WebCore/ForwardingHeaders/inspector/agent/InspectorAgent.h

[EFL EWS Bot]

Comment on attachment 220883 [details]
[PATCH] For Bots 1

Attachment 220883 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5845173598683136

[Joseph Pecoraro]

Created attachment 220892 [details]
[PATCH] For Bots 2

[kov's GTK+ EWS bot]

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/5179575134846976

[Joseph Pecoraro]

Woot, this looks good!

[Joseph Pecoraro]

Landed: <http://trac.webkit.org/changeset/161733>