126763 – Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController

Bug 126763 - Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController

Summary: Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorContro...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2014-01-10 10:54 PST by Joseph Pecoraro
Modified:	2014-01-10 21:15 PST (History)
CC List:	15 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (59.31 KB, patch) 2014-01-10 11:57 PST, Joseph Pecoraro	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
[PATCH] Proposed Fix (59.29 KB, patch) 2014-01-10 12:07 PST, Joseph Pecoraro	timothy: review+ eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
[PATCH] For Bots 1 (59.28 KB, patch) 2014-01-10 13:48 PST, Joseph Pecoraro	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
[PATCH] For Bots 2 (59.30 KB, patch) 2014-01-10 14:51 PST, Joseph Pecoraro	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joseph Pecoraro 2014-01-10 10:54:51 PST

Push down the first agent. The simple InspectorAgent agent!

Also, hook up the pipes and create a JSGlobalObjectInspectorController! You can now actually remotely inspect a JSGlobalObject and bits get sent back and forth! But, nothing exciting happens right now and the frontend would immediately throw an exception. Not concerned with that just yet until we get to RuntimeAgent.

Also, make WebCore use the Inspector::InspectorAgent.

Comment 1 Radar WebKit Bug Importer 2014-01-10 10:55:50 PST

<rdar://problem/15793721>

Comment 2 Joseph Pecoraro 2014-01-10 11:44:08 PST

Adding JSC engineers because the patch will make use of APIShims.

Comment 3 Joseph Pecoraro 2014-01-10 11:57:55 PST

Created attachment 220869 [details]
[PATCH] Proposed Fix

Comment 4 WebKit Commit Bot 2014-01-10 11:58:50 PST

Attachment 220869 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp', u'Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.h', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.cpp', u'Source/JavaScriptCore/inspector/agents/InspectorAgent.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/inspector/CommandLineAPIHost.cpp', u'Source/WebCore/inspector/CommandLineAPIHost.h', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InstrumentingAgents.h', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageConsoleAgent.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 5 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 EFL EWS Bot 2014-01-10 12:02:26 PST

Comment on attachment 220869 [details]
[PATCH] Proposed Fix

Attachment 220869 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6413797338120192

Comment 6 EFL EWS Bot 2014-01-10 12:04:25 PST

Comment on attachment 220869 [details]
[PATCH] Proposed Fix

Attachment 220869 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6209058797256704

Comment 7 Joseph Pecoraro 2014-01-10 12:07:41 PST

Created attachment 220873 [details]
[PATCH] Proposed Fix

Comment 8 EFL EWS Bot 2014-01-10 12:22:05 PST

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/6026769245143040

Comment 9 Timothy Hatcher 2014-01-10 12:26:40 PST

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=220873&action=review

Nice and clean.

> Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2014!

Comment 10 Timothy Hatcher 2014-01-10 12:28:05 PST

I'll let the JSC guys comment on APIShims if needed. r+ for everything else.

Comment 11 EFL EWS Bot 2014-01-10 12:28:13 PST

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5933584024076288

Comment 12 Joseph Pecoraro 2014-01-10 13:48:31 PST

Created attachment 220883 [details]
[PATCH] For Bots 1

I'll try including the Subdirectory in the forwarding path. So:
- Source/WebCore/ForwardingHeaders/inspector/InspectorAgent.h
+ Source/WebCore/ForwardingHeaders/inspector/agent/InspectorAgent.h

Comment 13 EFL EWS Bot 2014-01-10 14:23:00 PST

Comment on attachment 220883 [details]
[PATCH] For Bots 1

Attachment 220883 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/5845173598683136

Comment 14 Joseph Pecoraro 2014-01-10 14:51:16 PST

Created attachment 220892 [details]
[PATCH] For Bots 2

Comment 15 kov's GTK+ EWS bot 2014-01-10 19:40:09 PST

Comment on attachment 220873 [details]
[PATCH] Proposed Fix

Attachment 220873 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/5179575134846976

Comment 16 Joseph Pecoraro 2014-01-10 21:03:19 PST

Woot, this looks good!

Comment 17 Joseph Pecoraro 2014-01-10 21:15:04 PST

Landed: <http://trac.webkit.org/changeset/161733>