Bug 127206 - Run clang-modernize and let it add a bunch of missing overrides in WebCore/inspector
Summary: Run clang-modernize and let it add a bunch of missing overrides in WebCore/in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 17:05 PST by Joseph Pecoraro
Modified: 2014-01-20 13:50 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (84.80 KB, patch)
2014-01-17 17:07 PST, Joseph Pecoraro 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-17 17:05:17 PST 
Add missing overrides to WebCore/inspector with clang-modernize:

    shell> clang-modernize -add-override -p compile_commands.json -include ./inspector -summary
    Parse: /Users/pecoraro/Code/webkit/Source/WebCore/inspector
    Transform: AddOverride - Accepted: 1488
Comment 1 Joseph Pecoraro 2014-01-17 17:07:05 PST 
Created attachment 221514 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-01-17 17:08:25 PST 
Attachment 221514 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.h:77:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:276:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorCSSAgent.h:116:  The parameter name "pseudoIdMatches" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.h:107:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2014-01-20 13:50:02 PST 
Committed <http://trac.webkit.org/changeset/162369>.