Bug 126927 - [GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target
Summary: [GTK] Multiple definitions of PluginPackage symbols when only enabling Waylan...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
: 126426 (view as bug list)
Depends on:
Blocks: 81456
  Show dependency tree / graph
 
Reported: 2014-01-13 12:23 PST by Zan Dobersek
Modified: 2016-09-06 05:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2014-01-13 12:24 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (2.26 KB, patch)
2014-01-15 23:42 PST, Zan Dobersek 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-01-13 12:23:37 PST 
[GTK] Multiple definitions of PluginPackage symbols when only enabling Wayland target
Comment 1 Zan Dobersek 2014-01-13 12:24:32 PST 
Created attachment 221073 [details]
Patch
Comment 2 Alberto Garcia 2014-01-15 04:26:43 PST 
*** Bug 126426 has been marked as a duplicate of this bug. ***
Comment 3 Alberto Garcia 2014-01-15 04:29:56 PST 
(In reply to comment #1)
> Created an attachment (id=221073) [details]

This is a revert of r159999, so this would probably reopen bug 123997
Comment 4 Zan Dobersek 2014-01-15 07:33:16 PST 
The GTK port doesn't support disabling ENABLE_NETSCAPE_PLUGIN_API because AFAIR the WK2 plugin process doesn't build, and the support for building without the plugin process was removed (at least for the GTK port).

That's why the GTK port always includes PluginPackage.cpp into the build, and then either uses PluginPackageGtk.cpp when the X11 target is enabled, PluginPackageWin.cpp when the Win32 target is enabled, and PluginPackageNone.cpp when only the Wayland target is enabled. The proposed patch works for us, but would probably indeed reopen bug #123997.

I won't force any port into specific configurations, so I'll add the ENABLE(NETSCAPE_PLUGIN_API) guards around the added code. This should work out OK for everyone.
Comment 5 Zan Dobersek 2014-01-15 23:42:47 PST 
Created attachment 221337 [details]
Patch
Comment 6 Michael Catanzaro 2016-01-02 09:14:41 PST 
This patch adds a FIXME relevant to the EFL port.
Comment 7 Carlos Garcia Campos 2016-09-02 22:53:36 PDT 
Did this patch land? or is this still a problem with current trunk?
Comment 8 Carlos Garcia Campos 2016-09-06 05:03:02 PDT 
I know some people are building wayland only and nobody else complained about this. Feel free to reopen if this is still a problem with current trunk.