When the build-webkit script is called with --efl --no-netscape-api-plugin options, ld raises some 'undefined reference to' errors.
Created attachment 216307 [details] End of the build log. When the netscape_plugin_api is turned off, the efl build uses an alternative mock implementation that misses to implement these methods, which are called from the PluginDatabase.
Created attachment 216674 [details] Corrects --efl --no-netscape-plugin-api build failure.
Comment on attachment 216674 [details] Corrects --efl --no-netscape-plugin-api build failure. View in context: https://bugs.webkit.org/attachment.cgi?id=216674&action=review > Source/WebCore/plugins/PluginPackageNone.cpp:52 > +PassRefPtr<PluginPackage> PluginPackage::createPackage(const String& path, const time_t& lastModified) The 'path' and 'lastModified' will result unused parameter warnings (IMHO), we should remove those names. > Source/WebCore/plugins/PluginPackageNone.cpp:62 > +bool PluginPackage::equal(const PluginPackage& a, const PluginPackage& b) Ditto: Unused parameter warnings.
Created attachment 217193 [details] Fixes --efl --no-netscape-plugin-api build failure. Due to some recent commits, it failed at another point too. Both are corrected now.
LGTM
Comment on attachment 217193 [details] Fixes --efl --no-netscape-plugin-api build failure. View in context: https://bugs.webkit.org/attachment.cgi?id=217193&action=review > Source/WebKit2/UIProcess/API/C/WKPluginSiteDataManager.cpp:44 > + return toAPI(API::Object::Type::Null); It seems someone else already committed this fix into the trunk.
Fixed in r159788 (bug 124884).
Created attachment 218153 [details] Updated patch.
Comment on attachment 218153 [details] Updated patch. r=me
Comment on attachment 218153 [details] Updated patch. Clearing flags on attachment: 218153 Committed r159999: <http://trac.webkit.org/changeset/159999>
All reviewed patches have been landed. Closing bug.