Currently, the most spellchecking tests are using synchronous implementation. To ensure code coverage we should refactor them to use its asynchronous version.
I am working on this and I'm likely to share it next week.
Created attachment 219753 [details] worker This is first attempt to use asynchronous spellchecking in layout tests. It'll probably turn Mac bot red, However I'd like to see yours comments.
Created attachment 219754 [details] rebase a patch
Created attachment 219755 [details] trying 'git diff --binary'
Comment on attachment 219755 [details] trying 'git diff --binary' Attachment 219755 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/50328081 New failing tests: editing/spelling/spelling-insert-html.html editing/spelling/spellcheck-paste-disabled.html editing/spelling/grammar.html editing/spelling/inline_spelling_markers.html editing/spelling/inline-spelling-markers-hidpi.html editing/spelling/grammar-edit-word.html
Created attachment 219760 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 219755 [details] trying 'git diff --binary' Attachment 219755 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/50558036 New failing tests: editing/spelling/inline_spelling_markers.html editing/spelling/inline-spelling-markers-hidpi.html editing/spelling/markers.html editing/spelling/spelling-insert-html.html
Created attachment 219762 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 219755 [details] trying 'git diff --binary' Attachment 219755 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46678206 New failing tests: editing/spelling/spelling-insert-html.html editing/spelling/spellcheck-paste-disabled.html editing/spelling/grammar.html editing/spelling/inline_spelling_markers.html editing/spelling/inline-spelling-markers-hidpi.html editing/spelling/grammar-edit-word.html
Created attachment 219764 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Looks like the tests are failing on Mac?
(In reply to comment #11) > Looks like the tests are failing on Mac? Right. Those basically check grammar which I could not test due to only Mac supports it. I'll take care of them.
Created attachment 220615 [details] attempt to fix grammar tests Git info: 58 files changed, 1049 insertions(+), 923 deletions(-)
Created attachment 220616 [details] patch
Attachment 220616 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection.html', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection.html', u'LayoutTests/editing/spelling/design-mode-spellcheck-off-expected.txt', u'LayoutTests/editing/spelling/design-mode-spellcheck-off.html', u'LayoutTests/editing/spelling/grammar-edit-word-expected.txt', u'LayoutTests/editing/spelling/grammar-edit-word.html', u'LayoutTests/editing/spelling/grammar-expected.txt', u'LayoutTests/editing/spelling/grammar.html', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html', u'LayoutTests/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/editing/spelling/inline_spelling_markers.html', u'LayoutTests/editing/spelling/markers-expected.txt', u'LayoutTests/editing/spelling/markers.html', u'LayoutTests/editing/spelling/resources/util.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js', u'LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js', u'LayoutTests/editing/spelling/script-tests/spelling-hasspellingmarker.js', u'LayoutTests/editing/spelling/spellcheck-attribute-expected.txt', u'LayoutTests/editing/spelling/spellcheck-attribute.html', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html', u'LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-disabled.html', u'LayoutTests/editing/spelling/spelling-attribute-at-child-expected.txt', u'LayoutTests/editing/spelling/spelling-attribute-change-expected.txt', u'LayoutTests/editing/spelling/spelling-backspace-between-lines-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text.html', u'LayoutTests/editing/spelling/spelling-double-clicked-word-expected.txt', u'LayoutTests/editing/spelling/spelling-double-clicked-word.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-word-expected.txt', u'LayoutTests/editing/spelling/spelling-exactly-selected-word.html', u'LayoutTests/editing/spelling/spelling-hasspellingmarker-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html.html', u'LayoutTests/editing/spelling/spelling-linebreak-expected.txt', u'LayoutTests/editing/spelling/spelling-linebreak.html', u'LayoutTests/editing/spelling/spelling-should-select-multiple-words.html', u'LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt', u'LayoutTests/editing/spelling/spelling-unified-emulation.html', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection.html', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection.html', u'LayoutTests/platform/efl-wk2/TestExpectations', u'LayoutTests/platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/mac/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.png', '--commit-queue']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file lines = self._read_lines(file_path) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines contents = file.read() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220616 [details] patch Attachment 220616 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5197212954918912 New failing tests: editing/spelling/inline_spelling_markers.html editing/spelling/inline-spelling-markers-hidpi.html editing/spelling/markers.html editing/spelling/spelling-insert-html.html
Created attachment 220621 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 220616 [details] patch We need to mark new failing tests on mac-wk2 as it does not support async spellchecking yet (see bug 125690). I will add them in next patch.
Comment on attachment 220616 [details] patch Attachment 220616 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6215762704334848 New failing tests: editing/spelling/inline_spelling_markers.html editing/spelling/inline-spelling-markers-hidpi.html editing/spelling/markers.html editing/spelling/spelling-insert-html.html
Created attachment 220624 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 220616 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=220616&action=review > LayoutTests/ChangeLog:3 typo: Rafactoring -> Refactoring
Created attachment 220712 [details] Patch
Comment on attachment 220616 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=220616&action=review >> LayoutTests/ChangeLog:3 >> + Rafactoring spelling layout tests to use asynchronous path > > typo: Rafactoring -> Refactoring Thanks, fixed.
Attachment 220712 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection.html', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection.html', u'LayoutTests/editing/spelling/design-mode-spellcheck-off-expected.txt', u'LayoutTests/editing/spelling/design-mode-spellcheck-off.html', u'LayoutTests/editing/spelling/grammar-edit-word-expected.txt', u'LayoutTests/editing/spelling/grammar-edit-word.html', u'LayoutTests/editing/spelling/grammar-expected.txt', u'LayoutTests/editing/spelling/grammar.html', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html', u'LayoutTests/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/editing/spelling/inline_spelling_markers.html', u'LayoutTests/editing/spelling/markers-expected.txt', u'LayoutTests/editing/spelling/markers.html', u'LayoutTests/editing/spelling/resources/util.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js', u'LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js', u'LayoutTests/editing/spelling/script-tests/spelling-hasspellingmarker.js', u'LayoutTests/editing/spelling/spellcheck-attribute-expected.txt', u'LayoutTests/editing/spelling/spellcheck-attribute.html', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html', u'LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-disabled.html', u'LayoutTests/editing/spelling/spelling-attribute-at-child-expected.txt', u'LayoutTests/editing/spelling/spelling-attribute-change-expected.txt', u'LayoutTests/editing/spelling/spelling-backspace-between-lines-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text.html', u'LayoutTests/editing/spelling/spelling-double-clicked-word-expected.txt', u'LayoutTests/editing/spelling/spelling-double-clicked-word.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-word-expected.txt', u'LayoutTests/editing/spelling/spelling-exactly-selected-word.html', u'LayoutTests/editing/spelling/spelling-hasspellingmarker-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html.html', u'LayoutTests/editing/spelling/spelling-linebreak-expected.txt', u'LayoutTests/editing/spelling/spelling-linebreak.html', u'LayoutTests/editing/spelling/spelling-should-select-multiple-words.html', u'LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt', u'LayoutTests/editing/spelling/spelling-unified-emulation.html', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection.html', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection.html', u'LayoutTests/platform/efl-wk2/TestExpectations', u'LayoutTests/platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/mac-wk2/TestExpectations', u'LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt', '--commit-queue']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file lines = self._read_lines(file_path) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines contents = file.read() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 220712 [details] Patch Attachment 220712 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6628528388833280 New failing tests: editing/spelling/design-mode-spellcheck-off.html
Created attachment 220714 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 220716 [details] fix design-mode-spellcheck-off.html
Attachment 220716 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-multiword-selection.html', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection-expected.txt', u'LayoutTests/editing/spelling/context-menu-suggestions-subword-selection.html', u'LayoutTests/editing/spelling/design-mode-spellcheck-off-expected.txt', u'LayoutTests/editing/spelling/design-mode-spellcheck-off.html', u'LayoutTests/editing/spelling/grammar-edit-word-expected.txt', u'LayoutTests/editing/spelling/grammar-edit-word.html', u'LayoutTests/editing/spelling/grammar-expected.txt', u'LayoutTests/editing/spelling/grammar.html', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt', u'LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html', u'LayoutTests/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/editing/spelling/inline_spelling_markers.html', u'LayoutTests/editing/spelling/markers-expected.txt', u'LayoutTests/editing/spelling/markers.html', u'LayoutTests/editing/spelling/resources/util.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js', u'LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js', u'LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js', u'LayoutTests/editing/spelling/script-tests/spelling-hasspellingmarker.js', u'LayoutTests/editing/spelling/spellcheck-attribute-expected.txt', u'LayoutTests/editing/spelling/spellcheck-attribute.html', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-continuous-disabled.html', u'LayoutTests/editing/spelling/spellcheck-paste-disabled-expected.txt', u'LayoutTests/editing/spelling/spellcheck-paste-disabled.html', u'LayoutTests/editing/spelling/spelling-attribute-at-child-expected.txt', u'LayoutTests/editing/spelling/spelling-attribute-change-expected.txt', u'LayoutTests/editing/spelling/spelling-backspace-between-lines-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text-expected.txt', u'LayoutTests/editing/spelling/spelling-changed-text.html', u'LayoutTests/editing/spelling/spelling-double-clicked-word-expected.txt', u'LayoutTests/editing/spelling/spelling-double-clicked-word.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-multiple-words.html', u'LayoutTests/editing/spelling/spelling-exactly-selected-word-expected.txt', u'LayoutTests/editing/spelling/spelling-exactly-selected-word.html', u'LayoutTests/editing/spelling/spelling-hasspellingmarker-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html-expected.txt', u'LayoutTests/editing/spelling/spelling-insert-html.html', u'LayoutTests/editing/spelling/spelling-linebreak-expected.txt', u'LayoutTests/editing/spelling/spelling-linebreak.html', u'LayoutTests/editing/spelling/spelling-should-select-multiple-words.html', u'LayoutTests/editing/spelling/spelling-unified-emulation-expected.txt', u'LayoutTests/editing/spelling/spelling-unified-emulation.html', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-punctuation-selection.html', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection-expected.txt', u'LayoutTests/editing/spelling/spelling-with-whitespace-selection.html', u'LayoutTests/platform/efl-wk2/TestExpectations', u'LayoutTests/platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/efl/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/gtk/editing/spelling/inline_spelling_markers-expected.txt', u'LayoutTests/platform/mac-wk2/TestExpectations', u'LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png', u'LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.txt', '--commit-queue']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file lines = self._read_lines(file_path) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines contents = file.read() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte If any of these errors are false positives, please file a bug against check-webkit-style.
Hi Ryosuke, Alexey and Darin. I'm looking forward to see your comments. The latest patch contains pixel rebaseline which cause style error that I've never seen before.
Comment on attachment 220716 [details] fix design-mode-spellcheck-off.html View in context: https://bugs.webkit.org/attachment.cgi?id=220716&action=review I'm sorry this patch is way too big. Could you split this up into smaller patches so that we can do more thorough review of the patch? > LayoutTests/ChangeLog:45 > + elements, affects mouse down's position. Now Its margin is 16. Nit: its. (I should not be capitalized). > LayoutTests/ChangeLog:46 > + Origin description was created by single <p> and its margin was 8. Original? What are you referring to by "origin description"? > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:5 > +<head> > +<script src="../../resources/js-test-pre.js"></script> > +</head> We don't need to add head just to include a script. Put this in the body. > LayoutTests/editing/spelling/design-mode-spellcheck-off.html:-14 > -if (document.activeElement != document.body) > - document.body.appendChild(document.createTextNode('FAIL: active element before click is not body element')); Where did this check disappear? > LayoutTests/editing/spelling/grammar-edit-word-expected.txt:-21 > -document.execCommand("InsertText", false, "You has the right.") > -PASS internals.hasGrammarMarker(4, 3) is true > -Delete the end of this sentence until it becomes "You ha". > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -testRunner.execCommand("DeleteBackward") > -PASS internals.hasGrammarMarker(4, 2) is false Removing these lines is not great. Now I have no idea what offset 4 and 3 and 2 means in this output.
> style error that I've never seen before. This is tracked in bug 126702. Looks like the error started to happen recently.
(In reply to comment #30) > (From update of attachment 220716 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220716&action=review > > Could you split this up into smaller patches so that we can do more thorough review of the patch? > Sure, let's make this a master bug tracking spelling layout tests changes. Added a smaller patch bug 126895