Bug 125688 - Get rid of a synchronous spellchecking in a favour of an asynchronous one
Summary: Get rid of a synchronous spellchecking in a favour of an asynchronous one
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 118643 125689 125690 132048
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-13 03:24 PST by Grzegorz Czajkowski
Modified: 2014-04-23 01:12 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2013-12-13 03:24:30 PST 
This is a master bug to track removing of the synchronous spelling implementation.

Asynchronous spellchecking seems to be quite stable. What's more, it engages both UIProcess and WebProcess (in WK2) to perform spelling. As a result, UI is not blocked when the spelling or grammar is being performed (browsing dictionaries etc).
Comment 1 Grzegorz Czajkowski 2013-12-13 04:35:44 PST 
As far as I know there are three four WebKit ports that implement spellchecking.

   Port    | WK1 sync spell | WK1 async spell | WK2 sync spell | WK2 async
--------------------------------------------------------------------------
   Mac     |       +        |        +        |        +       |        -
   Gtk     |       +        |        -        |        +       |        -
   Efl     |       -        |        -        |        +       |        +
Blackberry |       -        |        +        |       N/A      |       N/A

Before changes in WebCore I think we should deliver port implementation for asynchronous spellchecking for Mac-WK2 and GTK-WK1/2 (added corresponding bugs).
Comment 2 Sam Weinig 2013-12-13 12:05:00 PST 
This would be great. Is there anything I can do to help get the Mac WebKit2 Async Spell check going?  Do you know what aspect is not implemented?
Comment 3 Grzegorz Czajkowski 2013-12-14 11:32:25 PST 
(In reply to comment #2)
> This would be great. Is there anything I can do to help get the Mac WebKit2 Async Spell check going?  Do you know what aspect is not implemented?

I'd be glad if you could take over bug 125690. I tried to summarize what should be done there. However, Enrica explained some time ago that there are some issues with Mac spelling/autocoration (details at bug 93611, comment 24.)