RESOLVED FIXED 128305
Verify misspellings after lines merge/split asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128305
Summary Verify misspellings after lines merge/split asynchronously
Grzegorz Czajkowski
Reported 2014-02-06 06:35:30 PST
Adapt the following spelling tests: - editing/spelling/spelling-backspace-between-lines.html - editing/spelling/spelling-linebreak.html to use asynchronous spellchecking.
Attachments
Patch (11.28 KB, patch)
2014-02-06 06:38 PST, Grzegorz Czajkowski
rniwa: review+
Grzegorz Czajkowski
Comment 1 2014-02-06 06:38:11 PST
Ryosuke Niwa
Comment 2 2014-02-06 15:24:09 PST
Comment on attachment 223330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223330&action=review > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:16 > + div.setAttribute("id", targetName); Just use .id = ~. > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:17 > + div.setAttribute("contentEditable", true); Ditto
Grzegorz Czajkowski
Comment 3 2014-02-07 00:56:13 PST
(In reply to comment #2) > (From update of attachment 223330 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223330&action=review > > > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:16 > > + div.setAttribute("id", targetName); > > Just use .id = ~. > > > LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js:17 > > + div.setAttribute("contentEditable", true); > > Ditto Thanks!. I'll apply them before lending.
Grzegorz Czajkowski
Comment 4 2014-02-07 01:15:51 PST
Note You need to log in before you can comment on or make changes to this bug.