Bug 124660 - [WebInspector] inspector-protocol/model/highlight-shape-outside.html is failing
Summary: [WebInspector] inspector-protocol/model/highlight-shape-outside.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 124070 131126
  Show dependency treegraph
 
Reported: 2013-11-20 08:11 PST by Michal Pakula vel Rutka
Modified: 2014-04-02 16:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.87 KB, patch)
2014-03-06 15:53 PST, Bear Travis
no flags Details | Formatted Diff | Diff
Patch (11.04 KB, patch)
2014-04-02 13:27 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
Patch (11.01 KB, patch)
2014-04-02 13:29 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2013-11-20 08:11:24 PST
Layout test: inspector-protocol/model/highlight-shape-outside.html is failing since it was introduced in r159070 <http://trac.webkit.org/changeset/159070>


Test output:
--- /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/inspector-protocol/model/highlight-shape-outside-expected.txt
+++ /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/inspector-protocol/model/highlight-shape-outside-actual.txt
@@ -1,9 +1,9 @@
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
 PASS: Actual [M 50 50 L 100 50 L 100 100 L 50 100 Z] Expected [M 50 50 L 100 50 L 100 100 L 50 100 Z]
-PASS: Actual [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 75 75 L 175 75 L 175 125 L 75 125 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 75 75 L 175 75 L 175 125 L 75 125 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
Comment 1 Bear Travis 2013-12-05 14:34:27 PST
Adding to the Shapes Inspector bug.
The platform implementation of addRect is closing the path slightly differently.
Comment 2 BJ Burg 2014-03-05 18:20:33 PST
The test inspector-protocol/model/highlight-shape-outside-margin.html test fails too.

Both of these will be migrated to the new inspector test harness tracked by https://webkit.org/b/129217. I will update the TestExpectations files.
Comment 3 Bear Travis 2014-03-06 15:53:14 PST
Created attachment 226056 [details]
Patch
Comment 4 Bear Travis 2014-03-06 15:56:07 PST
I had forgotten this test was added to TestExpectations. What does the highlight-shape-outside-margin failure look like?
Comment 5 Gyuyoung Kim 2014-03-31 01:04:37 PDT
Comment on attachment 226056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226056&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] inspector-protocol/model/highlight-shape-outside.html is failing

Doesn't we need to use *WebInspector* prefix instead of [EFL] ?
Comment 6 Zoltan Horvath 2014-04-02 13:27:18 PDT
Created attachment 228420 [details]
Patch
Comment 7 Zoltan Horvath 2014-04-02 13:29:58 PDT
Created attachment 228421 [details]
Patch
Comment 8 Zoltan Horvath 2014-04-02 15:25:21 PDT
Comment on attachment 228421 [details]
Patch

Please note all the Inspector tests are disabled currently due to: Bug #129642, so if you want to run this test you have to pass --force to the test script.
Comment 9 WebKit Commit Bot 2014-04-02 16:07:03 PDT
Comment on attachment 228421 [details]
Patch

Clearing flags on attachment: 228421

Committed r166673: <http://trac.webkit.org/changeset/166673>
Comment 10 WebKit Commit Bot 2014-04-02 16:07:07 PDT
All reviewed patches have been landed.  Closing bug.