Bug 124660 – [WebInspector] inspector-protocol/model/highlight-shape-outside.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Michal Pakula vel Rutka]

Layout test: inspector-protocol/model/highlight-shape-outside.html is failing since it was introduced in r159070 <http://trac.webkit.org/changeset/159070>


Test output:
--- /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/inspector-protocol/model/highlight-shape-outside-expected.txt
+++ /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/inspector-protocol/model/highlight-shape-outside-actual.txt
@@ -1,9 +1,9 @@
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
 PASS: Actual [M 50 50 L 100 50 L 100 100 L 50 100 Z] Expected [M 50 50 L 100 50 L 100 100 L 50 100 Z]
-PASS: Actual [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
-PASS: Actual [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
-PASS: Actual [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 75 75 L 175 75 L 175 125 L 75 125 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]
+FAIL: Actual [M 75 75 L 175 75 L 175 125 L 75 125 Z] Expected [M 75 75 L 175 75 L 175 125 L 75 125 L 75 75 Z]
+FAIL: Actual [M 50 50 L 150 50 L 150 100 L 50 100 Z] Expected [M 50 50 L 150 50 L 150 100 L 50 100 L 50 50 Z]

[Bear Travis]

Adding to the Shapes Inspector bug.
The platform implementation of addRect is closing the path slightly differently.

[Blaze Burg]

The test inspector-protocol/model/highlight-shape-outside-margin.html test fails too.

Both of these will be migrated to the new inspector test harness tracked by https://webkit.org/b/129217. I will update the TestExpectations files.

[Bear Travis]

Created attachment 226056 [details]
Patch

[Bear Travis]

I had forgotten this test was added to TestExpectations. What does the highlight-shape-outside-margin failure look like?

[Gyuyoung Kim]

Comment on attachment 226056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226056&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] inspector-protocol/model/highlight-shape-outside.html is failing

Doesn't we need to use *WebInspector* prefix instead of [EFL] ?

[Zoltan Horvath]

Created attachment 228420 [details]
Patch

[Zoltan Horvath]

Created attachment 228421 [details]
Patch

[Zoltan Horvath]

Comment on attachment 228421 [details]
Patch

Please note all the Inspector tests are disabled currently due to: Bug #129642, so if you want to run this test you have to pass --force to the test script.

[WebKit Commit Bot]

Comment on attachment 228421 [details]
Patch

Clearing flags on attachment: 228421

Committed r166673: <http://trac.webkit.org/changeset/166673>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.