Once https://bugs.webkit.org/show_bug.cgi?id=129190 is fixed, we can remove the special file-loading code from the InspectorTest.js. I would also like to move model/controller tests (those that use a full-blown inspector instead of just listeners for the raw protocol) to LayoutTests/inspector, and use a different inspector-test.js harness there.
<rdar://problem/16142670>
I am mostly done with this, but it may be blocked by flakiness of inspector/test-harness-trivially-works.html
Created attachment 226039 [details] the patch
Ready for review
Comment on attachment 226039 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226039&action=review > Source/WebInspectorUI/UserInterface/Test.html:87 > + <script src="Models/Profile.js"></script> > + <script src="Models/ProfileNode.js"></script> > + <script src="Models/ProfileNodeCall.js"></script> > + <script src="Models/TimelineRecord.js"></script> > + <script src="Models/LayoutTimelineRecord.js"></script> > + <script src="Models/ResourceTimelineRecord.js"></script> > + <script src="Models/ScriptTimelineRecord.js"></script> > + <script src="Models/Timeline.js"></script> > + <script src="Models/NetworkTimeline.js"></script> > + <script src="Models/SourceCodeTimeline.js"></script> > + <script src="Models/TimelineMarker.js"></script> > + <script src="Models/TimelineRecording.js"></script> Should be sorted (and match Main.html).
Comment on attachment 226039 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=226039&action=review >> Source/WebInspectorUI/UserInterface/Test.html:87 >> + <script src="Models/TimelineRecording.js"></script> > > Should be sorted (and match Main.html). The subclassing tripped me up, will fix.
I will land this but the inspector directory is marked as skipped until https://webkit.org/b/129642 is fixed, as that assert could be hit on any test converted in this patch.
Committed <http://trac.webkit.org/changeset/165501>