Bug 129190 – Web Inspector: model tests should use a special Test.html inspector page

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Loading the entire Main.html page for replay and model tests is overkill and will make the tests too slow. Instead we should load a separate Test.html (which could be generated) that only loads models and controllers.

For WebKit2, we can create a new WebInspector message called createInspectorPageForTest() which navigates the page to a different URL. This can be called by the WK2 inspector client whenever InspectorController::isUnderTest() is true, so subsequent calls to showWebInspector() from the test runner just do the right thing.

For WebKit1, we can change the logic in WebInspectorClient::openInspectorFrontend implementations to load a different URL according to the passed-in InspectorController, or we can ask the InspectorController what page to load. A naive implementation might not play nice with bundles and frameworks, however.

[Radar WebKit Bug Importer]

<rdar://problem/16140738>

[Timothy Hatcher]

This should be easy no that the UserInterface folder is segregated.

[Blaze Burg]

Created attachment 225208 [details]
the patch

[WebKit Commit Bot]

Attachment 225208 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:111:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Unfortunately the approach of resetting internals to a consistent state when first injecting it is probably responsible for a lot of test failures. I may have to make a separate method to do that.

[Build Bot]

Comment on attachment 225208 [details]
the patch

Attachment 225208 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5620999726825472

New failing tests:
media/track/track-css-user-override.html
fast/canvas/webgl/webgl-reload-crash.html
fast/profiler/multiple-frames.html
fast/frames/flattening/iframe-flattening-crash.html
http/tests/security/xssAuditor/get-from-iframe.html
http/tests/webgl/1.0.2/texImage2DHTML.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/forms/basic-textareas.html
fast/images/exif-orientation.html
inspector-protocol/dom/dom-search-crash.html
fast/spatial-navigation/snav-iframe-flattening-simple.html
http/tests/security/xssAuditor/xss-protection-parsing-01.html
http/tests/security/xssAuditor/cached-frame.html
fast/events/popup-blocked-from-iframe-script.html
fast/canvas/webgl/context-release-upon-reload.html
http/tests/security/xssAuditor/full-block-get-from-iframe.html
platform/mac/accessibility/iframe-aria-hidden.html
fast/spatial-navigation/snav-iframe-nested.html
fast/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html
svg/masking/mask-negative-scale.svg
http/tests/security/xssAuditor/post-from-iframe.html
fast/spatial-navigation/snav-search-optimization.html
fast/parser/pre-html5-parser-quirks.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
fast/spatial-navigation/snav-iframe-no-scrollable-content.html
http/tests/webgl/1.0.2/texSubImage2DHTML.html
fast/spatial-navigation/snav-iframe-recursive-offset-parent.html
fast/events/popup-blocked-from-iframe-src.html
fast/dom/HTMLDocument/hasFocus.html
fast/spatial-navigation/snav-iframe-no-focusable-content.html

[Build Bot]

Created attachment 225236 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 225208 [details]
the patch

Attachment 225208 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5314270443077632

New failing tests:
media/track/track-css-user-override.html
webgl/1.0.1/conformance/more/functions/bufferDataBadArgs.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-A.html
fast/profiler/multiple-frames.html
webgl/1.0.1/conformance/more/functions/bindBufferBadArgs.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-B1.html
fast/frames/flattening/iframe-flattening-crash.html
webgl/1.0.1/conformance/more/functions/copyTexImage2DBadArgs.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-C.html
fast/frames/flattening/frameset-flattening-subframe-resize.html
fast/forms/basic-textareas.html
webgl/1.0.1/conformance/more/functions/drawArrays.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-S_V.html
http/tests/security/xssAuditor/xss-protection-parsing-01.html
http/tests/security/xssAuditor/cached-frame.html
fast/events/popup-blocked-from-iframe-script.html
svg/masking/mask-negative-scale.svg
http/tests/security/xssAuditor/full-block-get-from-iframe.html
webgl/1.0.1/conformance/more/functions/drawArraysOutOfBounds.html
platform/mac/accessibility/iframe-aria-hidden.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-G_I.html
webgl/1.0.1/conformance/more/functions/bufferSubDataBadArgs.html
http/tests/security/xssAuditor/post-from-iframe.html
http/tests/security/xssAuditor/full-block-post-from-iframe.html
http/tests/security/xssAuditor/get-from-iframe.html
webgl/1.0.1/conformance/glsl/misc/uniform-location-length-limits.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-D_G.html
webgl/1.0.1/conformance/more/conformance/quickCheckAPI-B2.html
fast/events/popup-blocked-from-iframe-src.html
webgl/1.0.1/conformance/more/functions/copyTexSubImage2DBadArgs.html

[Build Bot]

Created attachment 225253 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Blaze Burg]

Created attachment 225286 [details]
patch, now with less fail

[WebKit Commit Bot]

Attachment 225286 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:111:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 225286 [details]
patch, now with less fail

Attachment 225286 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6246613890629632

New failing tests:
media/track/track-css-user-override.html
fast/profiler/multiple-frames.html
platform/mac/accessibility/iframe-aria-hidden.html

[Build Bot]

Created attachment 225293 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 225286 [details]
patch, now with less fail

Attachment 225286 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5383906895331328

New failing tests:
media/track/track-css-user-override.html
svg/masking/mask-negative-scale.svg
fast/profiler/multiple-frames.html
platform/mac/accessibility/iframe-aria-hidden.html

[Build Bot]

Created attachment 225300 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 225286 [details]
patch, now with less fail

Attachment 225286 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6255068533751808

New failing tests:
media/track/track-css-user-override.html
platform/mac/accessibility/iframe-aria-hidden.html
fast/profiler/multiple-frames.html

[Build Bot]

Created attachment 225313 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Blaze Burg]

This patch is ready to be reviewed. There are 3-4 remaining test failures, and I would appreciate any help diagnosing. Some of them (WebGL, etc) seem to be fixed on ToT.

[Blaze Burg]

Created attachment 225391 [details]
patch, now with even less fail

[WebKit Commit Bot]

Attachment 225391 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/WebPage/WebInspector.cpp:111:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Timothy Hatcher]

Comment on attachment 225391 [details]
patch, now with even less fail

View in context: https://bugs.webkit.org/attachment.cgi?id=225391&action=review

> Source/WebInspectorUI/UserInterface/Base/Test.js:28
> +WebInspector.loaded = function()
> +{
> +    // Register observers for events from the InspectorBackend.

A comment about matching Main.js order?

> Source/WebInspectorUI/UserInterface/Protocol/InspectorObserver.js:36
> +    // FIXME: remove plumbing for callIdentifier parameter from backend, as it's not used.

Nit: remove should be Remove

> Source/WebInspectorUI/UserInterface/Test.html:33
> +    <!--
> +    Each subsection is alphabetical, with the exception that base classes must
> +    be loaded before any classes that inherit from the base class are loaded.
> +    -->

This is correct. But just say 'match Main.html order/grouping'? Note: I left a similar comment out of Main.html to prevent it from shipping with a comment.

> Source/WebInspectorUI/UserInterface/Test.html:109
> +<div id="docked-resizer"></div>
> +<div id="toolbar"></div>
> +<div id="main">
> +    <div id="navigation-sidebar"></div>
> +    <div id="content">
> +        <div id="content-browser"></div>
> +        <div id="split-content-browser" class="hidden"></div>
> +        <div id="quick-console"></div>
> +    </div>
> +    <div id="details-sidebar"></div>
> +</div>

None of this should be needed. Right?

> LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js:161
> +// FIXME: move model tests off of the stub inspector page, and delete this function

Nit: move should be Move

[Blaze Burg]

Comment on attachment 225391 [details]
patch, now with even less fail

View in context: https://bugs.webkit.org/attachment.cgi?id=225391&action=review

>> Source/WebInspectorUI/UserInterface/Base/Test.js:28
>> +    // Register observers for events from the InspectorBackend.
> 
> A comment about matching Main.js order?

OK

[Blaze Burg]

Committed r164830: <http://trac.webkit.org/changeset/164830>