Bug 124578 - Remove WTF:: prefix from types in messages.in files.
Summary: Remove WTF:: prefix from types in messages.in files.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 125142
  Show dependency tree / graph
 
Reported: 2013-11-19 05:46 PST by Tamas Gergely
Modified: 2013-12-03 11:35 PST (History)
24 users (show)

See Also:

Attachments
Removes WTF prefix from messages.in files, 1st try. (74.65 KB, patch)
2013-11-19 05:59 PST, Tamas Gergely 		no flags Details | Formatted Diff | Diff
Removes WTF prefix from messages.in files, update. (74.87 KB, patch)
2013-11-29 07:22 PST, Tamas Gergely 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Removes WTF prefix from messages.in files, update for mac. (75.88 KB, patch)
2013-12-02 00:25 PST, Tamas Gergely 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-11-19 05:46:09 PST 
From the bug 123095 a comment came which describes that the all WTF:: prefixes (not only for template classes) should be removed from the messages.in files.
Comment 1 Tamas Gergely 2013-11-19 05:59:49 PST 
Created attachment 217292 [details]
Removes WTF prefix from messages.in files, 1st try.
Comment 2 Csaba Osztrogonác 2013-11-29 02:49:23 PST 
LGTM, but it needs a WK2 owner review.
Comment 3 Tamas Gergely 2013-11-29 07:22:09 PST 
Created attachment 218065 [details]
Removes WTF prefix from messages.in files, update.
Comment 4 Build Bot 2013-11-29 07:32:25 PST 
Comment on attachment 218065 [details]
Removes WTF prefix from messages.in files, update.

Attachment 218065 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/39138172
Comment 5 Build Bot 2013-11-29 07:52:33 PST 
Comment on attachment 218065 [details]
Removes WTF prefix from messages.in files, update.

Attachment 218065 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/39138175
Comment 6 Tamas Gergely 2013-12-02 00:25:41 PST 
Created attachment 218145 [details]
Removes WTF prefix from messages.in files, update for mac.
Comment 7 Csaba Osztrogonác 2013-12-03 03:28:09 PST 
cc more WK2 owner, maybe one of the have time to review this patch.
The patch looks good to me, but the r+ can be set only WK2 owner.
Comment 8 WebKit Commit Bot 2013-12-03 11:35:54 PST 
Comment on attachment 218145 [details]
Removes WTF prefix from messages.in files, update for mac.

Clearing flags on attachment: 218145

Committed r160022: <http://trac.webkit.org/changeset/160022>
Comment 9 WebKit Commit Bot 2013-12-03 11:35:58 PST 
All reviewed patches have been landed.  Closing bug.