Bug 125142 - Style checker for .messages.in files (WTF:: prefix)
Summary: Style checker for .messages.in files (WTF:: prefix)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 124578
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-03 02:11 PST by Tamas Gergely
Modified: 2013-12-04 08:11 PST (History)
5 users (show)

See Also:

Attachments
patch adds .messages.in style checker. (8.39 KB, patch)
2013-12-03 02:40 PST, Tamas Gergely 		andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch adds .messages.in style checker. (8.43 KB, patch)
2013-12-04 05:18 PST, Tamas Gergely 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Updated patch. (8.42 KB, patch)
2013-12-04 07:19 PST, Tamas Gergely 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-12-03 02:11:15 PST 
WTF:: prefixes should not be used in .messages.in files as described in bug 124578. This issue could also be checked by a style checker for these files.
Comment 1 Tamas Gergely 2013-12-03 02:40:08 PST 
Created attachment 218281 [details]
patch adds .messages.in style checker.
Comment 2 WebKit Commit Bot 2013-12-03 11:35:20 PST 
Comment on attachment 218281 [details]
patch adds .messages.in style checker.

Rejecting attachment 218281 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 218281, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/42138184
Comment 3 Tamas Gergely 2013-12-04 05:18:13 PST 
Created attachment 218402 [details]
patch adds .messages.in style checker.

Fixed reviewer line in ChangeLog.
Comment 4 WebKit Commit Bot 2013-12-04 05:38:12 PST 
Comment on attachment 218402 [details]
patch adds .messages.in style checker.

Rejecting attachment 218402 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 218402, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patch at line 36:  

patching file Tools/Scripts/webkitpy/style/checker.py
Hunk #1 FAILED at 43.
Hunk #2 succeeded at 635 (offset 6 lines).
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/style/checker.py.rej
patching file Tools/Scripts/webkitpy/style/checkers/messagesin.py
patching file Tools/Scripts/webkitpy/style/checkers/messagesin_unittest.py

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/43188023
Comment 5 Tamas Gergely 2013-12-04 07:19:44 PST 
Created attachment 218408 [details]
Updated patch.
Comment 6 WebKit Commit Bot 2013-12-04 08:11:03 PST 
Comment on attachment 218408 [details]
Updated patch.

Clearing flags on attachment: 218408

Committed r160093: <http://trac.webkit.org/changeset/160093>
Comment 7 WebKit Commit Bot 2013-12-04 08:11:05 PST 
All reviewed patches have been landed.  Closing bug.