Bug 123095 - Remove unprefixed class template processing from message receiver generator.
Summary: Remove unprefixed class template processing from message receiver generator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-21 07:35 PDT by Tamas Gergely
Modified: 2013-11-26 02:11 PST (History)
11 users (show)

See Also:


Attachments
Removes handlig of unprefixed template classes. (25.21 KB, patch)
2013-10-21 07:49 PDT, Tamas Gergely
andersca: review-
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Handle no prefixed WTF template classes in messages.in files. (10.75 KB, patch)
2013-11-13 02:55 PST, Tamas Gergely
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-10-21 07:35:45 PDT
There is a FIXME in the WebKit2/Scripts/webkit2/messages.py around line 358.
Comment 1 Tamas Gergely 2013-10-21 07:49:10 PDT
Created attachment 214738 [details]
Removes handlig of unprefixed template classes.
Comment 2 EFL EWS Bot 2013-10-21 07:54:12 PDT
Comment on attachment 214738 [details]
Removes handlig of unprefixed template classes.

Attachment 214738 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/8858044
Comment 3 kov's GTK+ EWS bot 2013-10-21 07:55:53 PDT
Comment on attachment 214738 [details]
Removes handlig of unprefixed template classes.

Attachment 214738 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/8858045
Comment 4 Anders Carlsson 2013-10-21 07:58:56 PDT
Comment on attachment 214738 [details]
Removes handlig of unprefixed template classes.

Hmm, who added this FIXME?

I'd rather we followed the C++ namping convention where none of the WTF classes require the WTF prefix.
Comment 5 Csaba Osztrogonác 2013-10-21 08:04:54 PDT
(In reply to comment #4)
> (From update of attachment 214738 [details])
> Hmm, who added this FIXME?
It seems you added this FIXME in http://trac.webkit.org/changeset/142835/trunk/Source/WebKit2/Scripts/webkit2/messages.py

Could you remember why? :)
Comment 6 Tamas Gergely 2013-10-31 07:17:23 PDT
Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script?
Comment 7 Csaba Osztrogonác 2013-11-04 02:04:35 PST
(In reply to comment #6)
> Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script?

adding Anders to the cc list. 

(It seems reviewing patches don't add the reviewer automatically to the cc list)
Comment 8 Csaba Osztrogonác 2013-11-07 04:28:25 PST
Anders, could you give Tamás any hint what would you like to fix here?

- removing WTF::Vector class_template_type
- removing Vector class_template_type
- removing the FIXME you added without removing anything else
Comment 9 Csaba Osztrogonác 2013-11-12 08:52:49 PST
The r- 3 weeks before wasn't so constructive. Would you 
be so kind to share us what kind of fix do you mean?
Comment 10 Anders Carlsson 2013-11-12 09:11:38 PST
(In reply to comment #6)
> Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script?

Yup.
Comment 11 Tamas Gergely 2013-11-13 02:55:31 PST
Created attachment 216785 [details]
Handle no prefixed WTF template classes in messages.in files.
Comment 12 EFL EWS Bot 2013-11-13 03:07:59 PST
Comment on attachment 216785 [details]
Handle no prefixed WTF template classes in messages.in files.

Attachment 216785 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/22589893
Comment 13 Anders Carlsson 2013-11-13 08:40:45 PST
Comment on attachment 216785 [details]
Handle no prefixed WTF template classes in messages.in files.

Looks good. If you feel like removing WTF:: from other classes go right ahead.
Comment 14 Csaba Osztrogonác 2013-11-13 08:59:00 PST
Comment on attachment 216785 [details]
Handle no prefixed WTF template classes in messages.in files.

cq+, the EFL-WK2 fail seems to be an unrelated flakiness.
Comment 15 WebKit Commit Bot 2013-11-13 09:24:45 PST
Comment on attachment 216785 [details]
Handle no prefixed WTF template classes in messages.in files.

Clearing flags on attachment: 216785

Committed r159201: <http://trac.webkit.org/changeset/159201>
Comment 16 WebKit Commit Bot 2013-11-13 09:24:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 17 Tamas Gergely 2013-11-26 02:11:01 PST
(In reply to comment #13)
> (From update of attachment 216785 [details])
> Looks good. If you feel like removing WTF:: from other classes go right ahead.
Anders, I've reported the bug 124578 for this 'removing all WTF::' issue. Could you please check that?