RESOLVED FIXED Bug 123095
Remove unprefixed class template processing from message receiver generator. 
https://bugs.webkit.org/show_bug.cgi?id=123095
Summary Remove unprefixed class template processing from message receiver generator.
Tamas Gergely
Reported 2013-10-21 07:35:45 PDT
There is a FIXME in the WebKit2/Scripts/webkit2/messages.py around line 358.
Attachments
Removes handlig of unprefixed template classes. (25.21 KB, patch)
2013-10-21 07:49 PDT, Tamas Gergely 		andersca: review-
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Handle no prefixed WTF template classes in messages.in files. (10.75 KB, patch)
2013-11-13 02:55 PST, Tamas Gergely 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tamas Gergely
Comment 1 2013-10-21 07:49:10 PDT
Created attachment 214738 [details] Removes handlig of unprefixed template classes.
EFL EWS Bot
Comment 2 2013-10-21 07:54:12 PDT
Comment on attachment 214738 [details] Removes handlig of unprefixed template classes. Attachment 214738 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/8858044
kov's GTK+ EWS bot
Comment 3 2013-10-21 07:55:53 PDT
Comment on attachment 214738 [details] Removes handlig of unprefixed template classes. Attachment 214738 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/8858045
Anders Carlsson
Comment 4 2013-10-21 07:58:56 PDT
Comment on attachment 214738 [details] Removes handlig of unprefixed template classes. Hmm, who added this FIXME? I'd rather we followed the C++ namping convention where none of the WTF classes require the WTF prefix.
Csaba Osztrogonác
Comment 5 2013-10-21 08:04:54 PDT
(In reply to comment #4) > (From update of attachment 214738 [details]) > Hmm, who added this FIXME? It seems you added this FIXME in http://trac.webkit.org/changeset/142835/trunk/Source/WebKit2/Scripts/webkit2/messages.py Could you remember why? :)
Tamas Gergely
Comment 6 2013-10-31 07:17:23 PDT
Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script?
Csaba Osztrogonác
Comment 7 2013-11-04 02:04:35 PST
(In reply to comment #6) > Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script? adding Anders to the cc list. (It seems reviewing patches don't add the reviewer automatically to the cc list)
Csaba Osztrogonác
Comment 8 2013-11-07 04:28:25 PST
Anders, could you give Tamás any hint what would you like to fix here? - removing WTF::Vector class_template_type - removing Vector class_template_type - removing the FIXME you added without removing anything else
Csaba Osztrogonác
Comment 9 2013-11-12 08:52:49 PST
The r- 3 weeks before wasn't so constructive. Would you be so kind to share us what kind of fix do you mean?
Anders Carlsson
Comment 10 2013-11-12 09:11:38 PST
(In reply to comment #6) > Then should it be fixed in an opposed way when only unprefixed WTF classes are handled by the WebKit2/Scripts/webkit2/messages.py script? Yup.
Tamas Gergely
Comment 11 2013-11-13 02:55:31 PST
Created attachment 216785 [details] Handle no prefixed WTF template classes in messages.in files.
EFL EWS Bot
Comment 12 2013-11-13 03:07:59 PST
Comment on attachment 216785 [details] Handle no prefixed WTF template classes in messages.in files. Attachment 216785 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/22589893
Anders Carlsson
Comment 13 2013-11-13 08:40:45 PST
Comment on attachment 216785 [details] Handle no prefixed WTF template classes in messages.in files. Looks good. If you feel like removing WTF:: from other classes go right ahead.
Csaba Osztrogonác
Comment 14 2013-11-13 08:59:00 PST
Comment on attachment 216785 [details] Handle no prefixed WTF template classes in messages.in files. cq+, the EFL-WK2 fail seems to be an unrelated flakiness.
WebKit Commit Bot
Comment 15 2013-11-13 09:24:45 PST
Comment on attachment 216785 [details] Handle no prefixed WTF template classes in messages.in files. Clearing flags on attachment: 216785 Committed r159201: <http://trac.webkit.org/changeset/159201>
WebKit Commit Bot
Comment 16 2013-11-13 09:24:48 PST
All reviewed patches have been landed. Closing bug.
Tamas Gergely
Comment 17 2013-11-26 02:11:01 PST
(In reply to comment #13) > (From update of attachment 216785 [details]) > Looks good. If you feel like removing WTF:: from other classes go right ahead. Anders, I've reported the bug 124578 for this 'removing all WTF::' issue. Could you please check that?
Note You need to log in before you can comment on or make changes to this bug.