Bug 121875 - Enabling CSS3 Text on Mac
Summary: Enabling CSS3 Text on Mac
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks: 76173
  Show dependency treegraph
 
Reported: 2013-09-24 15:48 PDT by Myles C. Maxfield
Modified: 2019-02-03 21:56 PST (History)
11 users (show)

See Also:


Attachments
Patch (58.59 KB, patch)
2013-09-24 15:52 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (58.63 KB, patch)
2013-09-25 10:32 PDT, Myles C. Maxfield
beidson: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2013-09-24 15:48:41 PDT
Enabling CSS3 Text on Mac
Comment 1 Myles C. Maxfield 2013-09-24 15:52:28 PDT
Created attachment 212512 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-09-25 10:21:29 PDT
Comment on attachment 212512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212512&action=review

> LayoutTests/platform/mac/TestExpectations:906
>  # CSS3 Text support is not yet enabled (needs ENABLE_CSS3_TEXT).
> -webkit.org/b/58491 fast/css3-text/css3-text-decoration
> -webkit.org/b/76173 fast/css3-text/css3-text-align-last
> -webkit.org/b/99945 fast/css3-text/css3-text-justify [ Failure ]
> -webkit.org/b/112755 fast/css3-text/css3-text-indent [ Failure ImageOnlyFailure ]
> +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]

This comment doesn't appear to be true any more. What should it be saying?
Comment 3 Myles C. Maxfield 2013-09-25 10:30:08 PDT
Comment on attachment 212512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212512&action=review

>> LayoutTests/platform/mac/TestExpectations:906
>> +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]
> 
> This comment doesn't appear to be true any more. What should it be saying?

Oops, I missed the comment. I'll upload a modified version
Comment 4 Myles C. Maxfield 2013-09-25 10:32:33 PDT
Created attachment 212596 [details]
Patch
Comment 5 Tim Horton 2013-09-26 14:08:37 PDT
Comment on attachment 212596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212596&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Gotta fix this line. Remove it or explain why (I think there are no new tests because the tests already exist and you're turning them on? You should say that.

> Tools/Scripts/webkitperl/FeatureList.pm:201
> +      define => "ENABLE_CSS3_TEXT", default => (isAppleMacWebKit() || isEfl() || isGtk()), value => \$css3TextSupport },

Does it work on Windows/should we turn it on there too? Most webby features like this we try to keep in sync, I think.

> LayoutTests/platform/mac/TestExpectations:905
> +webkit.org/b/112755 fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html [ Failure ]

Why? Does it just need new expectations?
Comment 6 Myles C. Maxfield 2013-09-30 14:24:48 PDT
Reopened because we want to do this
Comment 7 Brady Eidson 2016-05-24 22:07:18 PDT
Comment on attachment 212596 [details]
Patch

Assuming that patches for review since 2013 are stale, r-
Comment 8 Ebrahim Byagowi 2017-10-17 02:56:58 PDT
BUMP