Add ExecState::uncheckedArgument and used it where possible to shrink code a bit
Created attachment 212280 [details] Patch
Comment on attachment 212280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212280&action=review r=me buuuuut.. > Source/JavaScriptCore/interpreter/CallFrame.h:246 > + JSValue uncheckedArgument(size_t argument) We should merge this with getArgumentUnsafe(). > Source/WebCore/bridge/objc/objc_instance.mm:269 > - for (unsigned i = 2; i < count ; i++) { > + for (unsigned i = 2; i < count; i++) { No switching to prefix increment style?
Comment on attachment 212280 [details] Patch Attachment 212280 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1907348 New failing tests: fast/canvas/webgl/uniform-location.html webgl/conformance/uniforms/null-uniform-location.html webgl/conformance/misc/bad-arguments-test.html webgl/conformance/uniforms/uniform-location.html webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/conformance/misc/null-object-behaviour.html fast/canvas/webgl/null-uniform-location.html webgl/conformance/state/gl-object-get-calls.html fast/canvas/webgl/context-lost.html fast/canvas/webgl/null-object-behaviour.html fast/canvas/webgl/gl-object-get-calls.html fast/canvas/webgl/bad-arguments-test.html
Created attachment 212284 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 212280 [details] Patch Attachment 212280 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2053059 New failing tests: fast/canvas/webgl/uniform-location.html webgl/conformance/uniforms/null-uniform-location.html webgl/conformance/misc/bad-arguments-test.html webgl/conformance/uniforms/uniform-location.html webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/conformance/misc/null-object-behaviour.html fast/canvas/webgl/null-uniform-location.html webgl/conformance/state/gl-object-get-calls.html fast/canvas/webgl/context-lost.html fast/canvas/webgl/null-object-behaviour.html fast/canvas/webgl/gl-object-get-calls.html fast/canvas/webgl/bad-arguments-test.html
Created attachment 212285 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 212280 [details] Patch Attachment 212280 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/2033109 New failing tests: fast/canvas/webgl/uniform-location.html webgl/conformance/uniforms/null-uniform-location.html webgl/conformance/misc/bad-arguments-test.html webgl/conformance/uniforms/uniform-location.html webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html webgl/conformance/misc/null-object-behaviour.html fast/canvas/webgl/null-uniform-location.html webgl/conformance/state/gl-object-get-calls.html fast/canvas/webgl/context-lost.html fast/canvas/webgl/null-object-behaviour.html fast/canvas/webgl/gl-object-get-calls.html fast/canvas/webgl/bad-arguments-test.html
Created attachment 212287 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Committed r156240: <http://trac.webkit.org/changeset/156240>
This change broke multiple WebGL tests: <http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r156241%20(13150)/results.html>.
Re-opened since this is blocked by bug 121758
https://bugs.webkit.org/show_bug.cgi?id=121759 has the fixes for the WebGL failures
There is also a failure in accessibility/accessibility-node-memory-management.html test. This is because the patch changes what's left on the stack in debug builds. Darin is going to add a setTimeout() before garbage collection to fix the test.