Bug 120151 - [Qt] DRT bug revealed/caused by r154300
Summary: [Qt] DRT bug revealed/caused by r154300
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Allan Sandfeld Jensen
URL:
Keywords: Qt, QtTriaged
Depends on: 120595
Blocks: 79666 119995
  Show dependency treegraph
 
Reported: 2013-08-22 01:52 PDT by Csaba Osztrogonác
Modified: 2013-09-02 01:37 PDT (History)
11 users (show)

See Also:


Attachments
Patch (2.53 KB, patch)
2013-08-22 05:01 PDT, Allan Sandfeld Jensen
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-08-22 01:52:40 PDT
After https://trac.webkit.org/changeset/154300 all dumpastext test started 
to fail on Qt WK1 and made Qt WK1 testers exit early after 500 failures.

See https://bugs.webkit.org/show_bug.cgi?id=119995#c14 and 
https://bugs.webkit.org/show_bug.cgi?id=119995#c15 for details.

(Just a note: I'm not working on Qt long time ago, so I can't 
and won't try to fix this bug. I just reported it by courtesy.)

But it would be great to fix it if you want greater test coverage than 0% 
for QtWebKit WK1. The bots can't catch any new regression come from JSC, 
WebCore, ... from r154300. (Now r154437 is the latest revision.)
Comment 1 Allan Sandfeld Jensen 2013-08-22 03:21:00 PDT
It seems that QtInstance never had a getOwnPropertyDescriptor implementation but had a getOwnPropertySlot implementation. This means the behavior of getOwnPropertyDescriptor changed after it got implemented using getOwnPropertySlot.
Comment 2 Allan Sandfeld Jensen 2013-08-22 05:01:39 PDT
Created attachment 209348 [details]
Patch
Comment 3 WebKit Commit Bot 2013-08-22 05:04:28 PDT
Attachment 209348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp']" exit_code: 1
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:776:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Allan Sandfeld Jensen 2013-08-22 05:45:15 PDT
Committed r154444: <http://trac.webkit.org/changeset/154444>