Bug 120595 - [Qt] REGRESSION(r154444): xss-DENIED test results changed
Summary: [Qt] REGRESSION(r154444): xss-DENIED test results changed
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Keywords: Qt
Depends on:
Blocks: 120151
  Show dependency treegraph
Reported: 2013-09-02 01:37 PDT by Zoltan Arvai
Modified: 2013-09-13 08:14 PDT (History)
9 users (show)

See Also:

layout-test-results-debug-r154875 (596.16 KB, application/zip)
2013-09-02 01:37 PDT, Zoltan Arvai
no flags Details
Patch (4.47 KB, patch)
2013-09-11 07:27 PDT, Allan Sandfeld Jensen
jturcotte: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (656.33 KB, application/zip)
2013-09-11 08:15 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Arvai 2013-09-02 01:37:57 PDT
Created attachment 210268 [details]

Some tests results changed after the patch in http://trac.webkit.org/changeset/154444.
After unsuccessful bisecting with applied patch in range r154300 and r154444, I applied the patch to r154291 and turned out the patch caused the failure.

On release bots:


On my local machine additionally fails with release:

on debug bots:

same as release

additionally failes

Debug r154875 test results are attached.

One example:

--- /home/azbest/webkit/WebKit/layout-test-results/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt
+++ /home/azbest/webkit/WebKit/layout-test-results/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-actual.txt
@@ -1,5 +1,3 @@
-CONSOLE MESSAGE: Blocked a frame with origin "" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
-CONSOLE MESSAGE: line 1: TypeError: undefined is not an object (evaluating 'target.document.body')
 This page opens a window to "", injects malicious code, and then navigates its opener to the victim. The opened window then tries to scripts its opener after reloading itself as a javascript URL.
 Code injected into window:
 <script>window.location = 'javascript:\'<script>function write(target, message) { target.document.body.innerHTML = message; }setTimeout(function() {write(window.opener, \\\'FAIL: XSS was allowed.\\\');}, 100);setTimeout(function() {write(window.opener.top.frames[1], \\\'SUCCESS: Window remained in original SecurityOrigin.\\\');}, 200);setTimeout(function() { if (window.testRunner) testRunner.globalFlag = true; }, 300);<\\\/script>\''</script>
@@ -13,4 +11,4 @@
 Frame: '<!--framePath //<!--frame1-->-->'
-SUCCESS: Window remained in original SecurityOrigin.
+This page doesn't do anything special.
Comment 1 Zoltan Arvai 2013-09-02 08:11:07 PDT
Skipped on Qt in http://trac.webkit.org/changeset/154952.
Comment 2 Allan Sandfeld Jensen 2013-09-11 07:27:11 PDT
Created attachment 211312 [details]
Comment 3 WebKit Commit Bot 2013-09-11 07:28:43 PDT
Attachment 211312 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/TestExpectations', u'Tools/ChangeLog', u'Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp']" exit_code: 1
Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:776:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Build Bot 2013-09-11 08:15:21 PDT
Comment on attachment 211312 [details]

Attachment 211312 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1787051

New failing tests:
Comment 5 Build Bot 2013-09-11 08:15:22 PDT
Created attachment 211315 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 6 Allan Sandfeld Jensen 2013-09-11 08:29:55 PDT
(In reply to comment #4)
> (From update of attachment 211312 [details])
> Attachment 211312 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/1787051
> New failing tests:
> compositing/reflections/load-video-in-reflection.html

The bot must be flaky, only Qt code was changed.
Comment 7 Jocelyn Turcotte 2013-09-13 07:55:34 PDT
Comment on attachment 211312 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=211312&action=review

> Tools/ChangeLog:3
> +        [Qt] REGRESSION(r154444): xss-DENIED test results changed Need a short description (OOPS!)

Please fix.
Comment 8 Allan Sandfeld Jensen 2013-09-13 08:14:17 PDT
Committed r155699: <http://trac.webkit.org/changeset/155699>