Bug 120045 – [CSS Grid Layout] Add support for named grid areas

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/9b90c91c3b6f61947ecacf1ffd33aea89e834b8c

This is the final change in adding support for named grid areas:
extending the resolution code to handle named grid areas.

The patch is trivial as it builds on a lot of the
existing grid handling code.

[Sergio Villar Senin]

(In reply to comment #0)
> Consider merging https://chromium.googlesource.com/chromium/blink/+/9b90c91c3b6f61947ecacf1ffd33aea89e834b8c
> 
> This is the final change in adding support for named grid areas:
> extending the resolution code to handle named grid areas.
> 
> The patch is trivial as it builds on a lot of the
> existing grid handling code.

The patch is indeed pretty simple but it requires the named grid area support which is not there yet

[Sergio Villar Senin]

We should merge first https://chromiumcodereview.appspot.com/22215002

    Allow grid positions to be named grid areas
    
    This change extends our handling of grid position to allow for
    named grid areas. This required to split the shorthands parsing
    between grid-{row|column} and grid-area as the rules for expanding
    are slightly different.  The patch reuses a lot of the existing logic
    to marshall the values into RenderStyle.
    
    One big difference after this change is that:
    
    grid-row: foobar / none;
    
    used to be rejected at parsing but is now allowed.

[Dean Jackson]

(In reply to comment #2)
> We should merge first https://chromiumcodereview.appspot.com/22215002

Which is:

https://chromium.googlesource.com/chromium/blink/+/10399972ce9e322f07c523acc171df2338b9eb0c

[Sergio Villar Senin]

Created attachment 215052 [details]
Patch

[Sergio Villar Senin]

Created attachment 215369 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/17118013

[EFL EWS Bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/17138014

[Build Bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/17098012

[Build Bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/17118017

[Build Bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/17118016

[kov's GTK+ EWS bot]

Comment on attachment 215369 [details]
Patch

Attachment 215369 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/17038021

[Sergio Villar Senin]

Created attachment 215372 [details]
Patch

Rebased against latest changes

[Sergio Villar Senin]

Committed r158744: <http://trac.webkit.org/changeset/158744>

[Sergio Villar Senin]

*** Bug 120044 has been marked as a duplicate of this bug. ***