This bug was hidden by the fix for the bug 105641, which basically prevented the selection to be rendered when crossing the FlowThread boundaries. Such fix is not correct, because instead of fixing the actual bug it adds restrictions on how the selection works with Regions. We need to properly fix the selection clearing operation, allowing selections to cross RenderFlow boundaries and select content from different Regions.
Created attachment 208425 [details] Patch
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1353447
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1405199
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1411318
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1369686
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1414328
Comment on attachment 208425 [details] Patch Attachment 208425 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1369685
Created attachment 208429 [details] Patch
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1385270
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1369695
Comment on attachment 208429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208429&action=review Not really my field of expertise, just doing an informal general review. > Source/WebCore/rendering/RenderView.cpp:782 > + bool cond = os && os != stop; Do not use "cond", use a more descriptive name. > Source/WebCore/rendering/RenderView.cpp:849 > + cond = o && o != stop; Ditto. > Source/WebCore/rendering/RenderView.cpp:873 > + } The code looks exactly the same than the above, would it be possible to refactor it in some function?
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1353465
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1414369
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1399219
Comment on attachment 208429 [details] Patch Attachment 208429 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1350447
Created attachment 208447 [details] Patch
Comment on attachment 208447 [details] Patch Patch looks fine, but you need a test.
Created attachment 208765 [details] Patch Added missing layout tests
Comment on attachment 208765 [details] Patch r=me
Comment on attachment 208765 [details] Patch Clearing flags on attachment: 208765 Committed r155058: <http://trac.webkit.org/changeset/155058>
All reviewed patches have been landed. Closing bug.