Bug 105641 - [CSS Regions] Selecting text through nested regions causes weird and unclearable selection
Summary: [CSS Regions] Selecting text through nested regions causes weird and uncleara...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 109228
  Show dependency treegraph
 
Reported: 2012-12-21 10:27 PST by Zoltan Horvath
Modified: 2013-02-07 13:53 PST (History)
4 users (show)

See Also:


Attachments
image from the unclearable selection (33.59 KB, image/png)
2012-12-21 10:27 PST, Zoltan Horvath
no flags Details
proposed patch (55.97 KB, patch)
2012-12-21 10:35 PST, Zoltan Horvath
hyatt: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2012-12-21 10:27:14 PST
If you have a region with a nested region inside what is rendered below the base region and you are trying select text
starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.
Comment 1 Zoltan Horvath 2012-12-21 10:27:59 PST
Created attachment 180533 [details]
image from the unclearable selection
Comment 2 Zoltan Horvath 2012-12-21 10:35:59 PST
Created attachment 180534 [details]
proposed patch
Comment 3 WebKit Review Bot 2012-12-21 11:13:13 PST
Comment on attachment 180534 [details]
proposed patch

Attachment 180534 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15458448

New failing tests:
fast/regions/selecting-text-through-different-region-flows.html
Comment 4 Zoltan Horvath 2013-01-07 10:22:05 PST
(In reply to comment #3)
> (From update of attachment 180534 [details])
> Attachment 180534 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/15458448
> 
> New failing tests:
> fast/regions/selecting-text-through-different-region-flows.html

It's just a missing result on that platform. I'm not going to add the result generated by my vmware-cr-linux, since it shows 1px difference compared to the results of the bots for some reason.
Comment 5 Dave Hyatt 2013-01-08 14:24:30 PST
Comment on attachment 180534 [details]
proposed patch

r=me
Comment 6 WebKit Review Bot 2013-01-08 15:12:38 PST
Comment on attachment 180534 [details]
proposed patch

Rejecting attachment 180534 [details] from commit-queue.

New failing tests:
fast/regions/selecting-text-through-different-region-flows.html
Full output: http://queues.webkit.org/results/15754446
Comment 7 Zoltan Horvath 2013-01-09 09:31:02 PST
Landed in http://trac.webkit.org/changeset/139197