Bug 119097 - Rename <input type='color'> functions in WebPageProxy, WebColorPicker,
Summary: Rename <input type='color'> functions in WebPageProxy, WebColorPicker,
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 61276
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-25 11:33 PDT by Ruth Fong
Modified: 2013-07-30 17:57 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.09 KB, patch)
2013-07-30 16:21 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Patch (9.47 KB, patch)
2013-07-30 16:33 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Patch (10.33 KB, patch)
2013-07-30 16:44 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Patch (10.25 KB, patch)
2013-07-30 16:52 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Patch (12.30 KB, patch)
2013-07-30 17:03 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruth Fong 2013-07-25 11:33:26 PDT 
In bug 119025, WebColorChooserProxy was renamed WebColorPicker. To reflect this change, the method names in WebColorPicker and WebPageProxy should be changed (i.e. setColorChooserColor -> setColorPickerColor).
Comment 1 Radar WebKit Bug Importer 2013-07-25 11:34:06 PDT 
<rdar://problem/14549771>
Comment 2 Ruth Fong 2013-07-30 16:21:45 PDT 
Created attachment 207781 [details]
Patch
Comment 3 Tim Horton 2013-07-30 16:23:40 PDT 
Comment on attachment 207781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207781&action=review

> Source/WebKit2/ChangeLog:8
> +        Renamed INPUT_TYPE_COLOR functions in UIProcess from ...colorChooser to ...colorPicker.

Please put the justification for making the WK2 and WebCore names different here.
Comment 4 Tim Horton 2013-07-30 16:24:01 PDT 
Comment on attachment 207781 [details]
Patch

Sam r+'d this too.
Comment 5 Early Warning System Bot 2013-07-30 16:26:29 PDT 
Comment on attachment 207781 [details]
Patch

Attachment 207781 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1293484
Comment 6 Ruth Fong 2013-07-30 16:33:10 PDT 
Created attachment 207782 [details]
Patch
Comment 7 Early Warning System Bot 2013-07-30 16:38:50 PDT 
Comment on attachment 207782 [details]
Patch

Attachment 207782 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1289570
Comment 8 Ruth Fong 2013-07-30 16:44:02 PDT 
Created attachment 207784 [details]
Patch
Comment 9 Early Warning System Bot 2013-07-30 16:49:08 PDT 
Comment on attachment 207784 [details]
Patch

Attachment 207784 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1283761
Comment 10 Ruth Fong 2013-07-30 16:52:30 PDT 
Created attachment 207785 [details]
Patch
Comment 11 Early Warning System Bot 2013-07-30 16:57:27 PDT 
Comment on attachment 207785 [details]
Patch

Attachment 207785 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1287534
Comment 12 Ruth Fong 2013-07-30 17:03:38 PDT 
Created attachment 207787 [details]
Patch
Comment 13 Tim Horton 2013-07-30 17:12:33 PDT 
Comment on attachment 207787 [details]
Patch

r+ assuming all the ports build
Comment 14 WebKit Commit Bot 2013-07-30 17:57:16 PDT 
Comment on attachment 207787 [details]
Patch

Clearing flags on attachment: 207787

Committed r153504: <http://trac.webkit.org/changeset/153504>
Comment 15 WebKit Commit Bot 2013-07-30 17:57:19 PDT 
All reviewed patches have been landed.  Closing bug.