RESOLVED FIXED 119097
Rename <input type='color'> functions in WebPageProxy, WebColorPicker, 
https://bugs.webkit.org/show_bug.cgi?id=119097
Summary Rename <input type='color'> functions in WebPageProxy, WebColorPicker,
Ruth Fong
Reported 2013-07-25 11:33:26 PDT
In bug 119025, WebColorChooserProxy was renamed WebColorPicker. To reflect this change, the method names in WebColorPicker and WebPageProxy should be changed (i.e. setColorChooserColor -> setColorPickerColor).
Attachments
Patch (9.09 KB, patch)
2013-07-30 16:21 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Patch (9.47 KB, patch)
2013-07-30 16:33 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2013-07-30 16:44 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Patch (10.25 KB, patch)
2013-07-30 16:52 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Patch (12.30 KB, patch)
2013-07-30 17:03 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-25 11:34:06 PDT
<rdar://problem/14549771>
Ruth Fong
Comment 2 2013-07-30 16:21:45 PDT
Created attachment 207781 [details] Patch
Tim Horton
Comment 3 2013-07-30 16:23:40 PDT
Comment on attachment 207781 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207781&action=review > Source/WebKit2/ChangeLog:8 > + Renamed INPUT_TYPE_COLOR functions in UIProcess from ...colorChooser to ...colorPicker. Please put the justification for making the WK2 and WebCore names different here.
Tim Horton
Comment 4 2013-07-30 16:24:01 PDT
Comment on attachment 207781 [details] Patch Sam r+'d this too.
Early Warning System Bot
Comment 5 2013-07-30 16:26:29 PDT
Comment on attachment 207781 [details] Patch Attachment 207781 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1293484
Ruth Fong
Comment 6 2013-07-30 16:33:10 PDT
Created attachment 207782 [details] Patch
Early Warning System Bot
Comment 7 2013-07-30 16:38:50 PDT
Comment on attachment 207782 [details] Patch Attachment 207782 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1289570
Ruth Fong
Comment 8 2013-07-30 16:44:02 PDT
Created attachment 207784 [details] Patch
Early Warning System Bot
Comment 9 2013-07-30 16:49:08 PDT
Comment on attachment 207784 [details] Patch Attachment 207784 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1283761
Ruth Fong
Comment 10 2013-07-30 16:52:30 PDT
Created attachment 207785 [details] Patch
Early Warning System Bot
Comment 11 2013-07-30 16:57:27 PDT
Comment on attachment 207785 [details] Patch Attachment 207785 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1287534
Ruth Fong
Comment 12 2013-07-30 17:03:38 PDT
Created attachment 207787 [details] Patch
Tim Horton
Comment 13 2013-07-30 17:12:33 PDT
Comment on attachment 207787 [details] Patch r+ assuming all the ports build
WebKit Commit Bot
Comment 14 2013-07-30 17:57:16 PDT
Comment on attachment 207787 [details] Patch Clearing flags on attachment: 207787 Committed r153504: <http://trac.webkit.org/changeset/153504>
WebKit Commit Bot
Comment 15 2013-07-30 17:57:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.