Bug 119025 – Rename WebColorChooserProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ruth Fong]

WebColorChooserProxy, which represents the color picker UI for an <input type='color'> element, suggests a one-to-one relationship with the WebColorChooser object. 

In bug 61276, the architecture will change so that only one  WebColorChooserProxy object exists for a given WebPageProxy, while there can be multiple WebColorChooser objects living in the WebProcess.

WebColorChooserProxy should be renamed to something like WebColorPickerUI that reflects its representation of the color picker UI.

[Radar WebKit Bug Importer]

<rdar://problem/14528039>

[Ruth Fong]

Created attachment 207410 [details]
Patch

[Early Warning System Bot]

Comment on attachment 207410 [details]
Patch

Attachment 207410 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1200027

[EFL EWS Bot]

Comment on attachment 207410 [details]
Patch

Attachment 207410 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1205034

[Brady Eidson]

Comment on attachment 207410 [details]
Patch

Should change it in all the build systems.

`grep -r WebColorChooserProxy.cpp <path/to/WebKit2>` should find everywhere you need to replace it.

[Tim Horton]

Comment on attachment 207410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207410&action=review

> Source/WebKit2/UIProcess/PageClient.h:190
> +    virtual PassRefPtr<WebColorPickerUI> createColorChooserProxy(WebPageProxy*, const WebCore::Color& initialColor, const WebCore::IntRect&) = 0;

This method is poorly named now, isn't it?

[Brady Eidson]

(In reply to comment #6)
> (From update of attachment 207410 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207410&action=review
> 
> > Source/WebKit2/UIProcess/PageClient.h:190
> > +    virtual PassRefPtr<WebColorPickerUI> createColorChooserProxy(WebPageProxy*, const WebCore::Color& initialColor, const WebCore::IntRect&) = 0;
> 
> This method is poorly named now, isn't it?


And is there any advantage to calling the new object WebColorPickerUI instead of WebColorPicker, considering that the abstract concept of a WebColorPicker encapsulates more than just its UI?

[Ruth Fong]

Comment on attachment 207410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207410&action=review

>>> Source/WebKit2/UIProcess/PageClient.h:190
>>> +    virtual PassRefPtr<WebColorPickerUI> createColorChooserProxy(WebPageProxy*, const WebCore::Color& initialColor, const WebCore::IntRect&) = 0;
>> 
>> This method is poorly named now, isn't it?
> 
> And is there any advantage to calling the new object WebColorPickerUI instead of WebColorPicker, considering that the abstract concept of a WebColorPicker encapsulates more than just its UI?

I think that the WebColorPicker(UI) object does represent UI representation of the color picker, whereas the WebColorChooser is the abstract representation for the <input type='color'> object.

[Ruth Fong]

Created attachment 207412 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Ruth Fong]

Created attachment 207417 [details]
Patch

[Brady Eidson]

Comment on attachment 207417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207417&action=review

> Source/WebKit2/ChangeLog:10
> +        Rename WebColorChooserProxy to WebColorPicker since the name WebColorChoooserProxy
> +        implies a one-to-one relationship with WebColorChooser, which will not be true when
> +        the patch for bug 61276 lands.

Nitpick - It's not even true *now*

Yes, the WebProcess has 1 WebColorChooser, and the UIProcess has 1 WebColorChooserProxy...  but they aren't actually connected.

The Object/ObjectProxy naming scheme is for a pair of objects that represent the identical object/concept on both sides of the IPC connection, so tightly intertwined that they message each other directly.

[Ruth Fong]

Created attachment 207422 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 207422 [details]
Patch

Rejecting attachment 207422 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 207422 [details]
Patch

Clearing flags on attachment: 207422

Committed r153108: <http://trac.webkit.org/changeset/153108>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.