Bug 119094 - Implement <input type='color'> for WK1
Summary: Implement <input type='color'> for WK1
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on: 61276
  Show dependency treegraph
Reported: 2013-07-25 10:41 PDT by Ruth Fong
Modified: 2015-09-04 22:36 PDT (History)
7 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Ruth Fong 2013-07-25 10:41:41 PDT
Currently, INPUT_TYPE_COLOR is disabled. When the patch for bug 61276, INPUT_TYPE_COLOR will be enabled. For WK1, a stub implementation of WebChromeClient::createColorChooser will be added, but a real implementation of <input type='color'> should be added to WK1.
Comment 1 Radar WebKit Bug Importer 2013-07-25 10:43:06 PDT
Comment 2 Mark Lam 2013-07-31 17:29:21 PDT
Skipped fast/forms/color/input-color-onchange-event.html in r153552: <http://trac.webkit.org/changeset/153552>.  The test will crash with an assertion failure on debug builds until this bug is fixed.

Please un-skip that test when this bug is fixed.
Comment 3 Mark Lam 2013-07-31 17:58:49 PDT
(In reply to comment #2)
> Skipped fast/forms/color/input-color-onchange-event.html

I changed this to expect "Crash Pass" since it only crashes on debug builds, and still passes on release builds.  Please remove this entry from the TestExpectation file when the bug is fixed.

Changed in r153554: <http://trac.webkit.org/changeset/153554>.
Comment 4 Alexey Proskuryakov 2015-09-04 22:36:48 PDT
fast/forms/color/color-suggestion-picker-crash-on-set-value.html is another affected test.

Having an ASSERT_NOT_REACHED is a wrong way to not to not implement a feature, we should never assert on legitimate code paths.