Bug 148844 - Import a Chromium <input type=color> test
Summary: Import a Chromium <input type=color> test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Honeycutt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-04 16:23 PDT by Jon Honeycutt
Modified: 2015-09-04 22:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.88 KB, patch)
2015-09-04 16:24 PDT, Jon Honeycutt 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2015-09-04 16:23:09 PDT 
Import a Chromium <input type=color> test that tests that no crash occurs when changing the color with the picker open.
Comment 1 Jon Honeycutt 2015-09-04 16:24:10 PDT 
Created attachment 260644 [details]
Patch
Comment 2 Jon Honeycutt 2015-09-04 17:34:13 PDT 
Committed r189408: <http://trac.webkit.org/changeset/189408>
Comment 3 Alexey Proskuryakov 2015-09-04 22:32:51 PDT 
This test asserts in WebKit1. Will skip for now, but this is really the wrong way to not implement a feature - we should not assert on legitimate code paths.

#if ENABLE(INPUT_TYPE_COLOR)
std::unique_ptr<ColorChooser> WebChromeClient::createColorChooser(ColorChooserClient* client, const Color& initialColor)
{
    // FIXME: Implement <input type='color'> for WK1 (Bug 119094).
    ASSERT_NOT_REACHED();
    return nullptr;
}
#endif