Bug 118812 – Convert MathML fraction tests to reftests

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

Follow-up of bug 118599.

[Frédéric Wang (:fredw)]

Created attachment 206913 [details]
Patch V1

[Frédéric Wang (:fredw)]

Created attachment 206975 [details]
Patch V2

Just refreshing the patch after the changes from bug 118601.

[chris fleizach]

Comment on attachment 206975 [details]
Patch V2

View in context: https://bugs.webkit.org/attachment.cgi?id=206975&action=review

> LayoutTests/mathml/presentation/fractions-linethickness.html:13
> +      <mfrac linethickness="thick"><mn>1</mn><mn>2</mn></mfrac>

we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing

> LayoutTests/mathml/presentation/fractions-mrow.html:9
> +    <!-- This verifies <mrow> elements used as numerator/denominator. -->

verifies <mrow> elements "can be" used as "the" num...

[Frédéric Wang (:fredw)]

(In reply to comment #3)
> (From update of attachment 206975 [details])
> we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing

These three values ("thin", "medium", "thick") are specific to mfrac so I guess that's why a test was already written for them. The named spaces ("thickmathspace" etc) can be used for arbitrary lengths and the test "positive-namedspace.html" should already verify all these values for mspace@width. I don't think it's worth checking them for linethickness or other length attributes?

[chris fleizach]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 206975 [details] [details])
> > we should probably also test the subtler variations (veryverythin) in this test or another test so we have something that verifies the parsing
> 
> These three values ("thin", "medium", "thick") are specific to mfrac so I guess that's why a test was already written for them. The named spaces ("thickmathspace" etc) can be used for arbitrary lengths and the test "positive-namedspace.html" should already verify all these values for mspace@width. I don't think it's worth checking them for linethickness or other length attributes?

Ok thanks. As long as they're tested elsewhere.

[Frédéric Wang (:fredw)]

Created attachment 206998 [details]
Patch V3

[WebKit Commit Bot]

Comment on attachment 206998 [details]
Patch V3

Clearing flags on attachment: 206998

Committed r152849: <http://trac.webkit.org/changeset/152849>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.