Bug 118853 – More conversions from MathML pixel tests to reftests

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

I've prepared more conversions to reftests. After that it should only remain things testing operators and radicals, but I'll probably wait Martin's code refactoring on stretchy operators before considering them.

I've removed row-alignment.xhtml since all its tests are already verified elsewhere.

I couldn't find a reliable way to convert xHeigth.xhtml. This seemed to have been written by François Sausset to test the internal MathML code (bug 41535) but this test for "vertical-align: middle" is artificial and does not correspond to anything that is described in the MathML spec (for example Gecko renders that differently). Even in the bug report, they do not seem to agree on the relevance of the test. When the implementation was rewritten with flexboxes, the test was modified again by Dave Barton and I suspect it became even less relevant. So I've removed this test too.

[Frédéric Wang (:fredw)]

Created attachment 206995 [details]
Patch V1

[Build Bot]

Comment on attachment 206995 [details]
Patch V1

Attachment 206995 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1110595

New failing tests:
mathml/presentation/fenced-mi.html

[Build Bot]

Created attachment 207000 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Frédéric Wang (:fredw)]

(In reply to comment #3)
> Created an attachment (id=207000) [details]
> Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
> 
> The attached test failures were seen while running run-webkit-tests on the mac-ews.
> Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

This looks like a bug on Mac. I've opened bug 118856.

[Build Bot]

Comment on attachment 206995 [details]
Patch V1

Attachment 206995 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1104562

New failing tests:
mathml/presentation/fenced-mi.html

[Build Bot]

Created attachment 207005 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Frédéric Wang (:fredw)]

Created attachment 207006 [details]
Patch V2

[chris fleizach]

Comment on attachment 207006 [details]
Patch V2

View in context: https://bugs.webkit.org/attachment.cgi?id=207006&action=review

> LayoutTests/ChangeLog:31
> +        * mathml/xHeight.xhtml: Removed.

is the xHeight test covered in one of the new tests?

> LayoutTests/mathml/presentation/tables-spans-dynamic.html:8
> +

can you add a comment what this one is testing

> LayoutTests/mathml/presentation/tables-spans.html:13
> +

can you add an explantation what this is testing

[Frédéric Wang (:fredw)]

(In reply to comment #8)
> (From update of attachment 207006 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207006&action=review
> 
> > LayoutTests/ChangeLog:31
> > +        * mathml/xHeight.xhtml: Removed.
> 
> is the xHeight test covered in one of the new tests?

No, see comment 0. This was added in bug 41535.

> 
> > LayoutTests/mathml/presentation/tables-spans-dynamic.html:8
> > +
> 
> can you add a comment what this one is testing
> 
> > LayoutTests/mathml/presentation/tables-spans.html:13
> > +
> 
> can you add an explantation what this is testing

OK, I will do so. They are basically testing the rowspan and columnspan attributes (rowspan and colspan in HTML). And one sets these attributes dynamically via Javascript.

[Frédéric Wang (:fredw)]

Created attachment 207073 [details]
Patch V3

Here is a new patch with comments for the tables-span* tests

[Frédéric Wang (:fredw)]

Comment on attachment 207073 [details]
Patch V3

Thanks for the review.

[WebKit Commit Bot]

Comment on attachment 207073 [details]
Patch V3

Rejecting attachment 207073 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 207073, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   9e234c3..1573a7e  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 152901 = 9e234c3371e5786a5033d4e125d1edc45640fa02
r152902 = 1573a7e21e7d883d1d8c48ed6358e5e4aec448f3
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/1099884

[Frédéric Wang (:fredw)]

Any idea what the problem is? Should I update my local git repository and refresh the patch?

[chris fleizach]

(In reply to comment #13)
> Any idea what the problem is? Should I update my local git repository and refresh the patch?

That's probably the easiest thing to try

[Frédéric Wang (:fredw)]

Created attachment 207109 [details]
Patch Final Version

OK, there were conflicts in the Mac's test expectations after my other changes that have just been committed.

[WebKit Commit Bot]

Comment on attachment 207109 [details]
Patch Final Version

Clearing flags on attachment: 207109

Committed r152923: <http://trac.webkit.org/changeset/152923>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.