Bug 118601 – Incorrect calculated width for mspace.

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Frédéric Wang (:fredw)]

Created attachment 206536 [details]
testcase

See the testcase.

I guess

RenderMathMLSpace::computePreferredLogicalWidths()

should just set the specified width and should not call

RenderMathMLBlock::computePreferredLogicalWidths()

[zalan]

Created attachment 206745 [details]
Patch

[Frédéric Wang (:fredw)]

@Zalan I've cc'ed to two related bugs on MathML metrics. I think this one can be fixed independently but I just want to make you aware of Martin Robinson's refactoring of the MathML code that removes the "preferred heights" computation.

[zalan]

(In reply to comment #2)
> @Zalan I've cc'ed to two related bugs on MathML metrics. I think this one can be fixed independently but I just want to make you aware of Martin Robinson's refactoring of the MathML code that removes the "preferred heights" computation.

good to know, thanks!

[Frédéric Wang (:fredw)]

In the test: <div> and </span> do not match. I'm not sure why you need to use a margin style. What about using <span style="display: inline-block; width: ...; height: ...; background: ...;"> as in the other mspace reftests? Also do you really need a platform-specific reference file for a reftest (see bug 118599)?

[zalan]

(In reply to comment #4)
> In the test: <div> and </span> do not match. I'm not sure why you need to use a margin style. What about using <span style="display: inline-block; width: ...; height: ...; background: ...;"> as in the other mspace reftests? Also do you really need a platform-specific reference file for a reftest (see bug 118599)?

I'll look into those. I also thought i didnt need the platform specific ref file for the reftest, but since the test framework was complaining, I added. I'll check again and will remove it. Thanks.

[zalan]

Created attachment 206772 [details]
Patch

[Stephanie Lewis]

Skipped Crashing tests in http://trac.webkit.org/changeset/152822 while waiting for a fix

[chris fleizach]

Comment on attachment 206772 [details]
Patch

OK

[Frédéric Wang (:fredw)]

Just a note: if bug 118812 is taken before that one, then you won't need to add the platform-specific reference for fractions. Of course that reference can also just be removed later.

[zalan]

(In reply to comment #9)
> Just a note: if bug 118812 is taken before that one, then you won't need to add the platform-specific reference for fractions. Of course that reference can also just be removed later.

I'll just commit this and bug 118812 will take care of the cleanup of the platform specific files.

[zalan]

Created attachment 206963 [details]
Patch for landing

[Frédéric Wang (:fredw)]

(In reply to comment #10)

> I'll just commit this and bug 118812 will take care of the cleanup of the platform specific files.

ok, sounds good to me.

[WebKit Commit Bot]

Comment on attachment 206963 [details]
Patch for landing

Clearing flags on attachment: 206963

Committed r152840: <http://trac.webkit.org/changeset/152840>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.