Bug 115864 – [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Qt

[Zoltan Horvath]

Qt-port runs all the CSS-Exclusion tests. If there is an test failiure when running the tests there is no way to test via QtTestBrowser. This patch enables the feature in QtTestBrowser.

[Zoltan Horvath]

Created attachment 201246 [details]
proposed patch

[Andreas Kling]

Comment on attachment 201246 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review

> Source/WebKit/qt/Api/qwebsettings.h:82
> +        CSSExclusionsEnabled,

I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility.

[Zoltan Horvath]

(In reply to comment #2)
> (From update of attachment 201246 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.h:82
> > +        CSSExclusionsEnabled,
> 
> I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility.

I don't want to break any compatibility. Do you know any way how to add this settings as a private setting?

[Zoltan Horvath]

Comment on attachment 201246 [details]
proposed patch

We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug.

[Simon Hausmann]

(In reply to comment #4)
> (From update of attachment 201246 [details])
> We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug.

I very much like that approach :)