Bug 115864 - [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser
: [Qt] CSS Exclusions feature is enabled in DRT, but not in QtTestBrowser
Status: RESOLVED INVALID
Product: WebKit
Classification: Unclassified
Component: WebKit Qt
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Zoltan Horvath
:
Depends on:
Blocks: 57311
  Show dependency treegraph
 
Reported: 2013-05-09 09:56 PDT by Zoltan Horvath
Modified: 2013-05-13 01:41 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (2.60 KB, patch)
2013-05-09 09:59 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-05-09 09:56:03 PDT
Qt-port runs all the CSS-Exclusion tests. If there is an test failiure when running the tests there is no way to test via QtTestBrowser. This patch enables the feature in QtTestBrowser.
Comment 1 Zoltan Horvath 2013-05-09 09:59:54 PDT
Created attachment 201246 [details]
proposed patch
Comment 2 Andreas Kling 2013-05-09 10:39:28 PDT
Comment on attachment 201246 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review

> Source/WebKit/qt/Api/qwebsettings.h:82
> +        CSSExclusionsEnabled,

I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility.
Comment 3 Zoltan Horvath 2013-05-09 11:14:24 PDT
(In reply to comment #2)
> (From update of attachment 201246 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=201246&action=review
> 
> > Source/WebKit/qt/Api/qwebsettings.h:82
> > +        CSSExclusionsEnabled,
> 
> I think this needs to go at the end of the enum, since this is public Qt API and this would break binary compatibility.

I don't want to break any compatibility. Do you know any way how to add this settings as a private setting?
Comment 4 Zoltan Horvath 2013-05-10 15:22:54 PDT
Comment on attachment 201246 [details]
proposed patch

We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug.
Comment 5 Simon Hausmann 2013-05-13 01:41:13 PDT
(In reply to comment #4)
> (From update of attachment 201246 [details])
> We are going to enable CSS Exclusions for WebCore in general in bug #115919, that will solve this issue as well. Closing bug.

I very much like that approach :)