Bug 115919 - [css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
Summary: [css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on:
Blocks: 89256 116059
  Show dependency treegraph
Reported: 2013-05-10 10:57 PDT by Bear Travis
Modified: 2013-05-14 10:39 PDT (History)
4 users (show)

See Also:

Initial Patch (5.91 KB, patch)
2013-05-10 11:42 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-05-10 10:57:27 PDT
To enable user testing, CSS Exclusions should be turned on in the WebKit nightlies.
For this particular feature, which has a runtime and compile-time flag, this can be accomplished by setting the default value of the runtime flag to true.
Comment 1 Bear Travis 2013-05-10 11:42:30 PDT
Created attachment 201369 [details]
Initial Patch
Comment 2 Dean Jackson 2013-05-13 11:07:52 PDT
Comment on attachment 201369 [details]
Initial Patch

Simon commented that it really should be areCSSExclusionsEnabled, but this is only the variable name so I don't think it matters.
Comment 3 WebKit Commit Bot 2013-05-13 11:36:35 PDT
Comment on attachment 201369 [details]
Initial Patch

Clearing flags on attachment: 201369

Committed r150025: <http://trac.webkit.org/changeset/150025>
Comment 4 WebKit Commit Bot 2013-05-13 11:36:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2013-05-13 13:34:31 PDT
This change has caused the following test to fail on EFL WK2:
Comment 6 Bear Travis 2013-05-13 13:39:57 PDT
Investigating test failure. If nothing else, Exclusions can be explicitly turned off for that test case.
Comment 9 Zoltan Arvai 2013-05-14 01:50:23 PDT
(In reply to comment #8)
> Here is the right link, sorry for the noise:
> http://build.webkit.sed.hu/results/x86-32%20Linux%20Qt%20Release%20WebKit2/r150056%20%2835480%29/fast/css/variables/var-inside-shape-diffs.html

CSS Variable is disabled on Qt. Next time I do more investigation before commenting, I swear :)
Comment 10 Bear Travis 2013-05-14 10:39:21 PDT
I have filed bug 116059 to track the css variable test regressions this patch has caused.
fast/css/variables/var-inside-shape in particular is buggy.