Bug 116059 - [css exclusions] fast/css/variables/var-inside-shape.html is failing
Summary: [css exclusions] fast/css/variables/var-inside-shape.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on: 115919
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-13 14:08 PDT by Bear Travis
Modified: 2013-06-12 10:01 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2013-05-17 02:14 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2013-05-13 14:08:52 PDT 
Toggling CSS Exclusions on by default has caused the test to fail.
Comment 1 Bear Travis 2013-05-13 15:35:38 PDT 
CSS Variables are not working with shape-inside. This was not diagnosed until Exclusions were toggled on by default in 115919, as the test expectation does not enable shape-inside.

The expectation ignored the non-variable shape-insides.
The test case did not correctly resolve the variable shape-insides.
Comment 2 Sergio Villar Senin 2013-05-16 10:08:57 PDT 
Working on this. Patch to follow.
Comment 3 Sergio Villar Senin 2013-05-17 02:14:04 PDT 
Created attachment 202051 [details]
Patch
Comment 4 Alexandru Chiculita 2013-06-12 09:56:00 PDT 
Comment on attachment 202051 [details]
Patch

Looks good.
Comment 5 Sergio Villar Senin 2013-06-12 10:01:31 PDT 
Comment on attachment 202051 [details]
Patch

Clearing flags on attachment: 202051

Committed r151506: <http://trac.webkit.org/changeset/151506>
Comment 6 Sergio Villar Senin 2013-06-12 10:01:41 PDT 
All reviewed patches have been landed.  Closing bug.