Bug 113291 - [EFL][Qt] Three inspector test are failing after r146840
Summary: [EFL][Qt] Three inspector test are failing after r146840
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 65829
Blocks: 79666
  Show dependency treegraph
Reported: 2013-03-26 03:22 PDT by Ádám Kallai
Modified: 2013-03-28 01:28 PDT (History)
7 users (show)

See Also:

proposed patch (10.83 KB, patch)
2013-03-26 08:11 PDT, Ádám Kallai
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ádám Kallai 2013-03-26 03:22:35 PDT
They are failing after http://trac.webkit.org/changeset/146840. The fails are same on both of ports. 

 * inspector/console/console-eval-syntax-error.html

--- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/console/console-eval-syntax-error-expected.txt
+++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/console/console-eval-syntax-error-actual.txt
@@ -1,5 +1,5 @@
 Tests that evaluating an expression with a syntax error in the console won't crash the browser. Bug 61194.
-SyntaxError: Expected an identifier but found '}' instead
+SyntaxError: Unexpected EOF

--- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-pause-in-eval-script-expected.txt
+++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/debugger/debugger-pause-in-eval-script-actual.txt
@@ -4,7 +4,7 @@
 Evaluated script in console.
 Script execution paused.
 Call stack:
-    0) testFunction (:3)
+    0) testFunction (:2)
 Script execution resumed.
 Debugger was disabled.
 * inspector/extensions/extensions-eval.html

--- /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/extensions/extensions-eval-expected.txt
+++ /ramdisk/qt-linux-32-release-NRWT/build/layout-test-results/inspector/extensions/extensions-eval-actual.txt
@@ -5,7 +5,7 @@
 RUNNING TEST: extension_testEvalConsoleAPI
 Evaluate: "function" (exception: undefined)
 RUNNING TEST: extension_testEvalDefinesGlobalSymbols
-Evaluate: {"func":"function","variable":42} (exception: undefined)
+Evaluate: {"func":"undefined","variable":42} (exception: undefined)
 RUNNING TEST: extension_testEvalOk
 Evaluate: {"str":"foo","num":42} (exception: undefined)
 RUNNING TEST: extension_testEvalStatement
Comment 1 Timothy Hatcher 2013-03-26 05:49:47 PDT
These results just need added to the platform expectations. They are correct.
Comment 2 Ádám Kallai 2013-03-26 05:53:26 PDT
Thanks for your quick response. I will add new baseline to Qt.
Comment 3 Ádám Kallai 2013-03-26 06:34:57 PDT
Added platform specific expected files in: http://trac.webkit.org/changeset/146876
Comment 4 Csaba Osztrogonác 2013-03-26 06:58:01 PDT
I'm against adding 3 same expected file (Mac/EFL/Qt) for one test.

It seems it is JSC/V8 related problem. As far as I remember there was
a consensus that in this case the platform independent result should
be the JSC specific result and the V8 specific should be in platform-chromium.

inspector/console/console-eval-syntax-error.html still have chromium
specific result, and its platform independent result is unused now,
so it should be updated for JSC platforms.

inspector/debugger/debugger-pause-in-eval-script.html and
inspector/extensions/extensions-eval.html don't have chromium
specific expected file now.
Comment 5 Timothy Hatcher 2013-03-26 07:12:24 PDT
Makes sense to me. JSC is in WebKit, V8 isn't.
Comment 6 Ádám Kallai 2013-03-26 08:11:07 PDT
Created attachment 195089 [details]
proposed patch

I uploaded a patch for the problem. Ossy thanks for your help. :)
Comment 7 Csaba Osztrogonác 2013-03-26 08:13:01 PDT
Comment on attachment 195089 [details]
proposed patch

r=me, but let's see if the Mac and the Chromium EWS is happy before landing.
Comment 8 Csaba Osztrogonác 2013-03-28 01:19:50 PDT
Comment on attachment 195089 [details]
proposed patch

EWS bots are green, let's land it.
Comment 9 WebKit Review Bot 2013-03-28 01:28:38 PDT
Comment on attachment 195089 [details]
proposed patch

Clearing flags on attachment: 195089

Committed r147083: <http://trac.webkit.org/changeset/147083>
Comment 10 WebKit Review Bot 2013-03-28 01:28:43 PDT
All reviewed patches have been landed.  Closing bug.