Bug 61194 – Chromium DevTools: Tab crashes with "Aw, snap!" on entering "(new Image())." in console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Tab crashes with "Aw, snap!" on entering "(new Image())." in console.

Introduced in https://bugs.webkit.org/show_bug.cgi?id=60800

[Yury Semikhatsky]

Created attachment 94388 [details]
Patch

[Yury Semikhatsky]

*** Bug 61237 has been marked as a duplicate of this bug. ***

[Yury Semikhatsky]

Committed r87145: <http://trac.webkit.org/changeset/87145>

[Adam Klein]

Reverted r87145 for reason:

Regression

Committed r87172: <http://trac.webkit.org/changeset/87172>

[Adam Klein]

(In reply to comment #4)
> Reverted r87145 for reason:
> 
> Regression
> 
> Committed r87172: <http://trac.webkit.org/changeset/87172>

Full rollout message:

Regression in LayoutTests/inspector/debugger/scripts-panel.html on Chromium Win & Linux.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Fdebugger%2Fscripts-panel.html&group=%40ToT%20-%20chromium.org

[Adam Klein]

Looking further at the dashboard, it looks like it's flakiness, not always-failure.  But this test seems to have been rock solid right up until this patch, so I still highly suspect it's related.

[Yury Semikhatsky]

(In reply to comment #6)
> Looking further at the dashboard, it looks like it's flakiness, not always-failure.  But this test seems to have been rock solid right up until this patch, so I still highly suspect it's related.

I cannot reproduce the failure locally. I'm going to reapply the patch since the problem seems to be in the test itself. Let's see if the flakiness will appear again and try to fix the test.

[Yury Semikhatsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/inspector/console/console-eval-syntax-error-expected.txt
	A	LayoutTests/inspector/console/console-eval-syntax-error.html
	A	LayoutTests/platform/chromium/inspector/console/console-eval-syntax-error-expected.txt
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
Committed r87278

[Yury Semikhatsky]

*** Bug 61471 has been marked as a duplicate of this bug. ***