Bug 113153 – [EFL] build fails if --no-tiled-backing-store option is used (accelerated compositing is disabled)

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ed Bartosh]

Created attachment 194747 [details]
use PlatformLayer only if accelerated compositing is used

It's impossible to build efl port as suggested here: https://lists.webkit.org/pipermail/webkit-efl/2012-November/000434.html
I'm trying to build webkit-efl this way because I have Ubuntu 12.10 and it suffers from xserver regression, mentioned in above email.

With accelerating composition disabled(--no-tiled-backing-store is used) efl build fails with this error:
WebCore/platform/graphics/TextTrackRepresentation.h:55:13: error: `PlatformLayer' does not name a type

This happens because PlatformLayer is defined only when accelerated composiging is used.

With below change build goes further:


However, it anyway breaks with this error:

[Ed Bartosh]

Created attachment 194748 [details]
Use needsAnim only for accelerated composing

[Ed Bartosh]

Second patch fixes this error:

Source/WebCore/page/animation/ImplicitAnimation.cpp: In member function `virtual void WebCore::ImplicitAnimation::animate(WebCore::CompositeAnimation*, WebCore::RenderObject*, const WebCore::RenderStyle*, WebCore::RenderStyle*, WTF::RefPtr<WebCore::RenderStyle>&)':
Source/WebCore/page/animation/ImplicitAnimation.cpp:81:10: error: unused variable `needsAnim' [-Werror=unused-variable]

[Ed Bartosh]

Created attachment 194749 [details]
use PlatformLayer only if accelerated compositing is used

[Ed Bartosh]

With great help from kalyank on #webkit-efl it turned out that 3d rendering should be also disabled. As --no-tiled-backing-store can't be used without disabling 3d rendering I'm proposing final patch, which fixes this issue. It obsoletes earlier patches.

[Ed Bartosh]

Building is still failing after all above changes. Now it fails with this error:
In file included from Source/WebCore/platform/graphics/efl/GraphicsContext3DEfl.cpp:27:0:
Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:56:13: error: `GraphicsSurfaceToken' does not name a type
Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.h:81:12: error: `GLPlatformContext' was not declared in this scope

I'll be posting errors here and when building is OK I'll attach the patch.

[Ed Bartosh]

Created attachment 194772 [details]
Patch

[Ed Bartosh]

Still not OK:
In file included from Source/WebKit2/PluginProcess/PluginControllerProxy.h:32:0,
from Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:27:
Source/WebKit2/WebProcess/Plugins/Plugin.h:269:58: 
error: `FloatPoint' in namespace `WebCore' does not name a type
Source/WebKit2/WebProcess/Plugins/Plugin.h:269:77: error: ISO C++ forbids declaration of `parameter' with no type [-fpermissive]

I'll update the patch when I fix this issue. Hopefully this is the last one as build went to 87% of completion.

[Ed Bartosh]

Created attachment 195435 [details]
fixes for EFL build with disabled accelerated composition

Fixed almost all issues.

[WebKit Review Bot]

Attachment 195435 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/animation/ImplicitAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/graphics/TextTrackRepresentation.cpp', u'Source/WebCore/platform/graphics/TextTrackRepresentation.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/efl/WKView.cpp', u'Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp', u'Source/WebKit2/UIProcess/API/efl/EvasGLContext.cpp', u'Source/WebKit2/UIProcess/API/efl/EvasGLContext.h', u'Source/WebKit2/UIProcess/API/efl/EvasGLSurface.cpp', u'Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h', u'Source/WebKit2/UIProcess/API/efl/EwkView.cpp', u'Source/WebKit2/UIProcess/API/efl/EwkView.h', u'Source/WebKit2/UIProcess/API/efl/SnapshotImageGL.cpp', u'Source/WebKit2/UIProcess/PageViewportController.cpp', u'Source/WebKit2/UIProcess/PageViewportController.h', u'Source/WebKit2/UIProcess/efl/PageViewportControllerClientEfl.cpp', u'Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp', u'Source/WebKit2/UIProcess/efl/WebView.cpp', u'Source/WebKit2/WebProcess/Plugins/Plugin.h', u'Source/cmake/OptionsEfl.cmake']" exit_code: 1
Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:17:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:19:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 5 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ed Bartosh]

Created attachment 195438 [details]
fixes for EFL build with disabled accelerated composition

[Gyuyoung Kim]

WebKit EFL decided to remove non coordinated graphics code path. 
https://lists.webkit.org/pipermail/webkit-efl/2013-February/000497.html

If we can't fix this problem on xorg, it would be good to consider to support --no-tiled-backing-store then.

CC'ing drott, Mikhail and kubo,

What's going on xserver 1.13.0 ?

[Laszlo Gombos]

My concern is that this build configuration will just continue to regress back to build failure all the time unless this is continuously tested and supported as this is in an area of the code that is changing frequently and very few has a need to turn this flag off.

[Ed Bartosh]

Created attachment 195715 [details]
Patch

[Ed Bartosh]

Created attachment 195720 [details]
Patch

[Ed Bartosh]

Created attachment 195723 [details]
Patch

[Kalyan]

(In reply to comment #15)
> Created an attachment (id=195723) [details]
> Pat

(In reply to comment #15)
> Created an attachment (id=195723) [details]
> Patch

You might want to separate them into separate bugs and make this as blocking on them.

[Ed Bartosh]

1. This bug became meta-bug. Splitted to 3 separate bugs as suggested by Kalyan in Comment #16.
2. Used #if USE(ACCELERATED_COMPOSITING) instead of USE(TILED_BACKING_STORE) preparing for getting rid of TILED_BACKING_STORE as suggested by Vyacheslav Ostapenko: https://lists.webkit.org/pipermail/webkit-efl/2013-March/000536.html
3. Build is 100% fixed.

Please, review.

[Ed Bartosh]

I'm not sure if I should change status to RESOLVED/FIXED or just leave it as UNCONFIRMED. Please, revert it back to UNCONFIRMED if needed.

[Gyuyoung Kim]

(In reply to comment #18)
> I'm not sure if I should change status to RESOLVED/FIXED or just leave it as UNCONFIRMED. Please, revert it back to UNCONFIRMED if needed.

You need to read this link : https://bugs.webkit.org/page.cgi?id=fields.html#status. We should find proper case for this bug.

[Ed Bartosh]

Gyuyoung, thank you for the link. As I have no more choice I'm reverting this bug and its dependencies to UNCONFIRMED state. Feel free to change it to more appropriate state if needed.

[Ed Bartosh]

Resolved as all dependent bugs have been resolved.