Here is the error:
In file included from /home/ed/git/wk/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.h:32:0,
/home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:58: error: `FloatPoint' in namespace `WebCore' does not name a type
/home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:77: error: ISO C++ forbids declaration of `parameter' with no type [-fpermissive]
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/PluginProcess/PluginControllerProxy.cpp.o] Error 1
make: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2
Created attachment 195816 [details]
Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status
LGTM. You need to get WK2 owner's sign off.
BTW, I wonder if this patch is only for EFL port. It looks this patch will be influence on other ports as well.
Changing to WK2 as suggested.
Comment on attachment 195816 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=195816&action=review
> + [EFL] --no-tiled-backing-store build fails because FloatPoint is not declared
Please fix the prefix here to match the bug title.
Created attachment 196522 [details]
Alexey, thank you for review. I'm sorry for the delay. I've missed your comment somehow.
Updated the patch according to your suggestion.
Simon, can you please review this really small one?
Comment on attachment 196522 [details]
Please just forward-declare to avoid extra includes.
Good point, I don't know what I was thinking when saying r+.
Created attachment 196690 [details]
Updated according to reviewer's suggestion. Please review.
Comment on attachment 196690 [details]
Clearing flags on attachment: 196690
Committed r147823: <http://trac.webkit.org/changeset/147823>
All reviewed patches have been landed. Closing bug.