Bug 113618 – [WK2] --no-backing-store build fails because FloatPoint is not declared

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Ed Bartosh]

Here is the error:
In file included from /home/ed/git/wk/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.h:32:0,
                 from /home/ed/git/wk/WebKit/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:27:
/home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:58: error: `FloatPoint' in namespace `WebCore' does not name a type
/home/ed/git/wk/WebKit/Source/WebKit2/WebProcess/Plugins/Plugin.h:270:77: error: ISO C++ forbids declaration of `parameter' with no type [-fpermissive]
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/PluginProcess/PluginControllerProxy.cpp.o] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2

[Ed Bartosh]

Created attachment 195816 [details]
Patch

[Ed Bartosh]

Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status

[Gyuyoung Kim]

LGTM. You need to get WK2 owner's sign off.

[Gyuyoung Kim]

BTW, I wonder if this patch is only for EFL port. It looks this patch will be influence on other ports as well.

[Ed Bartosh]

Changing to WK2 as suggested.

[Alexey Proskuryakov]

Comment on attachment 195816 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195816&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] --no-tiled-backing-store build fails because FloatPoint is not declared

Please fix the prefix here to match the bug title.

[Ed Bartosh]

Created attachment 196522 [details]
Patch

Alexey, thank you for review. I'm sorry for the delay. I've missed your comment somehow.
Updated the patch according to your suggestion.

[Ed Bartosh]

Simon, can you please review this really small one?

[Simon Fraser (smfr)]

Comment on attachment 196522 [details]
Patch

Please just forward-declare to avoid extra includes.

[Alexey Proskuryakov]

Good point, I don't know what I was thinking when saying r+.

[Ed Bartosh]

Created attachment 196690 [details]
Patch

[Ed Bartosh]

Updated according to reviewer's suggestion. Please review.

[WebKit Commit Bot]

Comment on attachment 196690 [details]
Patch

Clearing flags on attachment: 196690

Committed r147823: <http://trac.webkit.org/changeset/147823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.