Bug 113629 - [EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(COORDINATED_GRAPHICS)
Summary: [EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 113153
  Show dependency tree / graph
 
Reported: 2013-03-29 17:08 PDT by Ed Bartosh
Modified: 2013-04-05 12:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.01 KB, patch)
2013-03-29 17:20 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Patch (4.51 KB, patch)
2013-04-04 15:00 PDT, Ed Bartosh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Bartosh 2013-03-29 17:08:30 PDT 
Build fails with this kind of errors:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp: In function `OpaqueCGLayer* WKCoordinatedSceneFindScrollableContentsLayerAt(WKCoordinatedScene, WKPoint)':
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:40:31: error: invalid use of incomplete type `class WebCore::CoordinatedGraphicsScene'
In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:33:0:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:35:7: error: forward declaration of `class WebCore::CoordinatedGraphicsScene'
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:40:63: error: `FloatPoint' is not a member of `WebCore'
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp: In function `uint32_t WKCoordinatedSceneGetLayerID(WKCoordinatedSceneLayer)':
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:45:25: error: invalid use of incomplete type `class WebCore::TextureMapperLayer'
In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:33:0:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:36:7: error: forward declaration of `class WebCore::TextureMapperLayer'
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp: In function `void WKCoordinatedSceneScrollBy(WKCoordinatedSceneLayer, WKSize)':
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:50:18: error: invalid use of incomplete type `class WebCore::TextureMapperLayer'
In file included from /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:33:0:
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:36:7: error: forward declaration of `class WebCore::TextureMapperLayer'
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:50:29: error: `FloatSize' is not a member of `WebCore'
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp: In function `uint32_t WKCoordinatedSceneGetLayerID(WKCoordinatedSceneLayer)':
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:46:1: error: control reaches end of non-void function [-Werror=return-type]
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp: In function `OpaqueCGLayer* WKCoordinatedSceneFindScrollableContentsLayerAt(WKCoordinatedScene, WKPoint)':
/home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:41:1: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp.o] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2
make: *** [all] Error 2
Comment 1 Ed Bartosh 2013-03-29 17:20:50 PDT 
Created attachment 195824 [details]
Patch
Comment 2 Ed Bartosh 2013-04-01 01:06:46 PDT 
Reverting back to UNCONFIRMED after reading https://bugs.webkit.org/page.cgi?id=fields.html#status
Comment 3 Ed Bartosh 2013-04-01 04:04:07 PDT 
Added WK2 reviewer as patch also changes WK2 code.
Comment 4 Ed Bartosh 2013-04-04 15:00:40 PDT 
Created attachment 196535 [details]
Patch

Rebased. Please, review!
Comment 5 WebKit Commit Bot 2013-04-05 12:25:34 PDT 
Comment on attachment 196535 [details]
Patch

Clearing flags on attachment: 196535

Committed r147776: <http://trac.webkit.org/changeset/147776>
Comment 6 WebKit Commit Bot 2013-04-05 12:25:37 PDT 
All reviewed patches have been landed.  Closing bug.