Bug 112389 - [CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
Summary: [CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 103314
  Show dependency tree / graph
 
Reported: 2013-03-14 16:24 PDT by Julien Chaffraix
Modified: 2013-03-21 10:17 PDT (History)
7 users (show)

See Also:

Attachments
Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated. (24.18 KB, patch)
2013-03-14 16:33 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Patch for landing (42.33 KB, patch)
2013-03-21 09:23 PDT, Julien Chaffraix 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-03-14 16:24:28 PDT 
After bug 112299 and bug 112211, the code is in a state where we can easily implement the layout of the specification algorithm.

This bug will only implement the layout side of this, the preferred / implicit logical widths bits are deferred to bug 112388 as they need more thinking.
Comment 1 Julien Chaffraix 2013-03-14 16:33:53 PDT 
Created attachment 193199 [details]
Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated.
Comment 2 Tony Chang 2013-03-20 15:10:49 PDT 
Comment on attachment 193199 [details]
Proposed change 1: Algorithm close to the spec, not totally aligned though as the extra complexity need to be evaluated.

LGTM.  Please add some tests with bothRowBothColumn.
Comment 3 Julien Chaffraix 2013-03-21 09:23:32 PDT 
Created attachment 194278 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-03-21 10:17:20 PDT 
Comment on attachment 194278 [details]
Patch for landing

Clearing flags on attachment: 194278

Committed r146482: <http://trac.webkit.org/changeset/146482>
Comment 5 WebKit Review Bot 2013-03-21 10:17:23 PDT 
All reviewed patches have been landed.  Closing bug.