Bug 112211 - [CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
Summary: [CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Julien Chaffraix
URL:
Keywords:
Depends on:
Blocks: 103314
  Show dependency treegraph
 
Reported: 2013-03-12 17:04 PDT by Julien Chaffraix
Modified: 2013-03-13 15:30 PDT (History)
7 users (show)

See Also:


Attachments
Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse. (11.78 KB, patch)
2013-03-12 17:37 PDT, Julien Chaffraix
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2013-03-12 17:04:27 PDT
After bug 111653, we have the code to compute both initial / final positions in one direction and using GridSpan.

However this information is local and isn't propagated to most of the layout code. Instead of peppering more GridSpan computation, we should propagate the information through GridCoordinate. This is a good candidate as it is our golden representation of where an item is on the grid.
Comment 1 Julien Chaffraix 2013-03-12 17:37:33 PDT
Created attachment 192842 [details]
Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse.
Comment 2 WebKit Review Bot 2013-03-13 15:30:27 PDT
Comment on attachment 192842 [details]
Proposed change 1: Not super happy about the emptyGridArea change but a pair would be worse.

Clearing flags on attachment: 192842

Committed r145762: <http://trac.webkit.org/changeset/145762>
Comment 3 WebKit Review Bot 2013-03-13 15:30:31 PDT
All reviewed patches have been landed.  Closing bug.