accessibility/textbox-role-reports-selection.html is failing on all EFL platforms.
Created attachment 215480 [details]
Comment on attachment 215480 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=215480&action=review
Lgtm, but it would be good if you could address those style things first
Small description here?
> + No new tests, covered by existing ones.
> + getSelectionOffsetsForObject() now returns proper start/end offsets for
> + selections "touching" the object's front border.
You probably want to swap the order of these two paragraphs
Created attachment 215504 [details]
Comment on attachment 215504 [details]
Rejecting attachment 215504 [details] from commit-queue.
Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 215504, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit
Last 500 characters of output:
r158269 = 73d7044720a6f151ca09d9a163927f26af28a858
r158270 = 2ff8909f3a50ccf4628fa796cc700416611f040c
r158271 = 69b2545e8b2b2f8c4b9b5c7b11f931642ae78ca1
r158272 = 38466816b3824f830f62f68150d3fde7a55601ca
r158273 = 5d27aad1be1bad5a03a513014fa5e0534b5d2e0d
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Full output: http://webkit-queues.appspot.com/results/17038226
Created attachment 215627 [details]
Comment on attachment 215627 [details]
Clearing flags on attachment: 215627
Committed r158352: <http://trac.webkit.org/changeset/158352>
All reviewed patches have been landed. Closing bug.
*** Bug 67713 has been marked as a duplicate of this bug. ***