Bug 112016 - [EFL] accessibility/textarea-selected-text-range.html is failing
Summary: [EFL] accessibility/textarea-selected-text-range.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 98379 (view as bug list)
Depends on:
Blocks: 111985 112017
  Show dependency tree / graph
 
Reported: 2013-03-11 08:13 PDT by Krzysztof Czech
Modified: 2013-11-01 04:46 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (5.78 KB, patch)
2013-10-30 01:23 PDT, Rob Płóciennik 		no flags Details | Formatted Diff | Diff
Proposed patch (5.78 KB, patch)
2013-10-30 01:28 PDT, Rob Płóciennik 		mario: review+
Details | Formatted Diff | Diff
Updated patch (5.82 KB, patch)
2013-10-30 08:21 PDT, Rob Płóciennik 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-03-11 08:13:47 PDT 
accessibility/textarea-selected-text-range.html is failing on all EFL platforms.
Comment 1 Rob Płóciennik 2013-10-30 01:23:08 PDT 
Created attachment 215479 [details]
Proposed patch
Comment 2 Rob Płóciennik 2013-10-30 01:28:37 PDT 
Created attachment 215481 [details]
Proposed patch
Comment 3 Mario Sanchez Prada 2013-10-30 04:47:13 PDT 
Comment on attachment 215481 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215481&action=review

Lgtm, besides some small style nits.

> LayoutTests/ChangeLog:7
> +

We normally put a brief and generic description such as "Removed failure expectations" or the like

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1026
> +    gint start, end;
> +    g_free(atk_text_get_selection(ATK_TEXT(m_element), 0, &start, &end));

This g_free(...) thing is a weird idiom, but I guess it's fine here since you are only interested in the offsets. Ok

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1029
> +

Extra blank line not needed

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1169
> +

Extra line
Comment 4 Rob Płóciennik 2013-10-30 08:21:13 PDT 
Created attachment 215503 [details]
Updated patch

Updated the patch accordingly.
Comment 5 WebKit Commit Bot 2013-10-30 09:04:21 PDT 
Comment on attachment 215503 [details]
Updated patch

Clearing flags on attachment: 215503

Committed r158273: <http://trac.webkit.org/changeset/158273>
Comment 6 WebKit Commit Bot 2013-10-30 09:04:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Mario Sanchez Prada 2013-11-01 04:46:46 PDT 
*** Bug 98379 has been marked as a duplicate of this bug. ***