Bug 111075 – [WK2][EFL] WebView should own page position and scale factor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Mikhail Pozdnyakov]

SSIA.

[Mikhail Pozdnyakov]

Created attachment 190721 [details]
WIP

The code looks better now and EwkView usage is decreased inside WebView. But on the other hand 1) having scale factors both inside view and page is confusing 2) maybe it's better to use "viewport position" than "page position"?

[Kenneth Rohde Christiansen]

Comment on attachment 190721 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=190721&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:69
> +
> +void WKViewSetScaleFactor(WKViewRef viewRef, float scale)
> +{
> +    toImpl(viewRef)->setScaleFactor(scale);
> +}

Should this be SetPageScaleFactor for consistency?

[Mikhail Pozdnyakov]

(In reply to comment #2)
> (From update of attachment 190721 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190721&action=review
> 
> > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:69
> > +
> > +void WKViewSetScaleFactor(WKViewRef viewRef, float scale)
> > +{
> > +    toImpl(viewRef)->setScaleFactor(scale);
> > +}
> 
> Should this be SetPageScaleFactor for consistency?

wouldn't it be confusing for the client considering the existing 'void WKPageSetScaleFactor(WKPageRef page, double scale, WKPoint origin);' ?

[Mikhail Pozdnyakov]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 190721 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=190721&action=review
> > 
> > > Source/WebKit2/UIProcess/API/C/efl/WKView.cpp:69
> > > +
> > > +void WKViewSetScaleFactor(WKViewRef viewRef, float scale)
> > > +{
> > > +    toImpl(viewRef)->setScaleFactor(scale);
> > > +}
> > 
> > Should this be SetPageScaleFactor for consistency?
> 
> wouldn't it be confusing for the client considering the existing 'void WKPageSetScaleFactor(WKPageRef page, double scale, WKPoint origin);' ?

Having IRC discussion with Kenneth came to conclusion that WKViewSetContentScaleFactor would be most appropriate name for it.

[Mikhail Pozdnyakov]

Created attachment 193830 [details]
WIP 2

[Kenneth Rohde Christiansen]

Comment on attachment 193830 [details]
WIP 2

LGTM, but a good changelog explaining the difference between WKPageSetScaleFactor etc would be needed. Also explaining that these are in UI units

[Mikhail Pozdnyakov]

Created attachment 196615 [details]
patch

Rebased. Added change log.

[WebKit Commit Bot]

Comment on attachment 196615 [details]
patch

Clearing flags on attachment: 196615

Committed r147741: <http://trac.webkit.org/changeset/147741>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.