Bug 110345 - [WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
Summary: [WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl ou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 107657 107662
  Show dependency tree / graph
 
Reported: 2013-02-20 06:56 PST by Mikhail Pozdnyakov
Modified: 2013-02-21 04:00 PST (History)
9 users (show)

See Also:

Attachments
patch (8.74 KB, patch)
2013-02-20 07:45 PST, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-02-20 06:56:14 PST 
SSIA. WebView does not need to know about both PageViewportController and PageViewportControllerClientEfl. Considering the fact that PageViewportController will stop being WK2 internal and will be based on WK2 C API, it's worth moving it to Ewk API layer - into EwkView.
Comment 1 Mikhail Pozdnyakov 2013-02-20 07:45:39 PST 
Created attachment 189318 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2013-02-20 08:04:58 PST 
Comment on attachment 189318 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189318&action=review

LGTM

> Source/WebKit2/UIProcess/efl/WebView.cpp:155
> +        m_ewkView->pageViewportControllerClient()->updateViewportSize();

Would be nice to get rid of m_ewkView from this class
Comment 3 Mikhail Pozdnyakov 2013-02-20 23:12:23 PST 
(In reply to comment #2)
> (From update of attachment 189318 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=189318&action=review
> 
> LGTM
> 
> > Source/WebKit2/UIProcess/efl/WebView.cpp:155
> > +        m_ewkView->pageViewportControllerClient()->updateViewportSize();
> 
> Would be nice to get rid of m_ewkView from this class
Sure. We'll remove m_ewkView usage here via WKViewClient API extension.
Comment 4 WebKit Review Bot 2013-02-21 04:00:34 PST 
Comment on attachment 189318 [details]
patch

Clearing flags on attachment: 189318

Committed r143582: <http://trac.webkit.org/changeset/143582>
Comment 5 WebKit Review Bot 2013-02-21 04:00:39 PST 
All reviewed patches have been landed.  Closing bug.