Bug 107661 - [EFL][WK2] Use C API inside ewk_cookie_manager
Summary: [EFL][WK2] Use C API inside ewk_cookie_manager
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 107657 107666
  Show dependency treegraph
Reported: 2013-01-23 04:08 PST by Chris Dumez
Modified: 2013-01-23 10:23 PST (History)
9 users (show)

See Also:

Patch (15.16 KB, patch)
2013-01-23 05:31 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-01-23 04:08:40 PST
As per Bug 107657, we should start using the C API internally to avoid violating layering.
Comment 1 Chris Dumez 2013-01-23 05:31:53 PST
Created attachment 184208 [details]
Comment 2 WebKit Review Bot 2013-01-23 09:42:00 PST
Attachment 184208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/PlatformEfl.cmake', u'Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.cpp', u'Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h', u'Source/WebKit2/UIProcess/API/efl/ewk_context.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_cookie_manager_private.h']" exit_code: 1
Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h:36:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebKit2/UIProcess/API/C/soup/WKCookieManagerSoup.h:37:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-01-23 10:23:14 PST
Comment on attachment 184208 [details]

Clearing flags on attachment: 184208

Committed r140542: <http://trac.webkit.org/changeset/140542>
Comment 4 WebKit Review Bot 2013-01-23 10:23:19 PST
All reviewed patches have been landed.  Closing bug.