RESOLVED FIXED 107540
[V8] Remove if(isolate) checks from v8String() and v8Integer() 
https://bugs.webkit.org/show_bug.cgi?id=107540
Summary [V8] Remove if(isolate) checks from v8String() and v8Integer()
Kentaro Hara
Reported 2013-01-22 02:48:17 PST
Now there is no optional Isolate parameter in the code base (except for throwError()). We can safely remove if(isolate) checks from v8String() and v8Integer().
Attachments
Patch (7.82 KB, patch)
2013-01-22 02:50 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-01-22 02:50:33 PST
Created attachment 183946 [details] Patch
WebKit Review Bot
Comment 2 2013-01-22 09:27:00 PST
Comment on attachment 183946 [details] Patch Attachment 183946 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16063066 New failing tests: fast/constructors/constructor-as-function-crash.html fast/parser/nested-fragment-parser-crash.html plugins/netscape-plugin-property-access-exception.html fast/dom/TreeWalker/acceptNode-filter.html http/tests/workers/worker-importScriptsOnError.html fast/mediastream/constructors.html fast/events/constructors/message-event-constructor.html webintents/web-intents-invoke-port.html fast/dom/Window/window-postmessage-args.html fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fast/events/message-port-multi.html fast/dom/call-a-constructor-as-a-function.html fast/canvas/webgl/data-view-test.html fast/css/matrix-as-function-crash.html fast/mediastream/MediaStreamConstructor.html plugins/npruntime/throw-exception.html platform/chromium/virtual/gpu/fast/canvas/webgl/data-view-test.html
Adam Barth
Comment 3 2013-01-22 09:42:50 PST
Comment on attachment 183946 [details] Patch This is great, but it looks like you're breaking some tests.
Kentaro Hara
Comment 4 2013-01-22 16:37:06 PST
(In reply to comment #0) > Now there is no optional Isolate parameter in the code base (except for throwError()). ah, throwError() is calling v8String()... so I need to remove the optional Isolate parameter of throwError() first.
Kentaro Hara
Comment 5 2013-01-23 00:30:43 PST
Comment on attachment 183946 [details] Patch Now it should be safe to commit it.
WebKit Review Bot
Comment 6 2013-01-23 00:47:00 PST
Comment on attachment 183946 [details] Patch Clearing flags on attachment: 183946 Committed r140521: <http://trac.webkit.org/changeset/140521>
WebKit Review Bot
Comment 7 2013-01-23 00:47:04 PST
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 8 2013-01-23 05:17:31 PST
*** Bug 104239 has been marked as a duplicate of this bug. ***
Kentaro Hara
Comment 9 2013-01-23 05:17:42 PST
*** Bug 104236 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.