Now there is no optional Isolate parameter in the code base (except for throwError()). We can safely remove if(isolate) checks from v8String() and v8Integer().
Created attachment 183946 [details] Patch
Comment on attachment 183946 [details] Patch Attachment 183946 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16063066 New failing tests: fast/constructors/constructor-as-function-crash.html fast/parser/nested-fragment-parser-crash.html plugins/netscape-plugin-property-access-exception.html fast/dom/TreeWalker/acceptNode-filter.html http/tests/workers/worker-importScriptsOnError.html fast/mediastream/constructors.html fast/events/constructors/message-event-constructor.html webintents/web-intents-invoke-port.html fast/dom/Window/window-postmessage-args.html fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html fast/events/message-port-multi.html fast/dom/call-a-constructor-as-a-function.html fast/canvas/webgl/data-view-test.html fast/css/matrix-as-function-crash.html fast/mediastream/MediaStreamConstructor.html plugins/npruntime/throw-exception.html platform/chromium/virtual/gpu/fast/canvas/webgl/data-view-test.html
Comment on attachment 183946 [details] Patch This is great, but it looks like you're breaking some tests.
(In reply to comment #0) > Now there is no optional Isolate parameter in the code base (except for throwError()). ah, throwError() is calling v8String()... so I need to remove the optional Isolate parameter of throwError() first.
Comment on attachment 183946 [details] Patch Now it should be safe to commit it.
Comment on attachment 183946 [details] Patch Clearing flags on attachment: 183946 Committed r140521: <http://trac.webkit.org/changeset/140521>
All reviewed patches have been landed. Closing bug.
*** Bug 104239 has been marked as a duplicate of this bug. ***
*** Bug 104236 has been marked as a duplicate of this bug. ***