Bug 107540 - [V8] Remove if(isolate) checks from v8String() and v8Integer()
Summary: [V8] Remove if(isolate) checks from v8String() and v8Integer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
: 104236 104239 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-01-22 02:48 PST by Kentaro Hara
Modified: 2013-01-23 05:17 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.82 KB, patch)
2013-01-22 02:50 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-01-22 02:48:17 PST
Now there is no optional Isolate parameter in the code base (except for throwError()). We can safely remove if(isolate) checks from v8String() and v8Integer().
Comment 1 Kentaro Hara 2013-01-22 02:50:33 PST
Created attachment 183946 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-22 09:27:00 PST
Comment on attachment 183946 [details]
Patch

Attachment 183946 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16063066

New failing tests:
fast/constructors/constructor-as-function-crash.html
fast/parser/nested-fragment-parser-crash.html
plugins/netscape-plugin-property-access-exception.html
fast/dom/TreeWalker/acceptNode-filter.html
http/tests/workers/worker-importScriptsOnError.html
fast/mediastream/constructors.html
fast/events/constructors/message-event-constructor.html
webintents/web-intents-invoke-port.html
fast/dom/Window/window-postmessage-args.html
fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
fast/events/message-port-multi.html
fast/dom/call-a-constructor-as-a-function.html
fast/canvas/webgl/data-view-test.html
fast/css/matrix-as-function-crash.html
fast/mediastream/MediaStreamConstructor.html
plugins/npruntime/throw-exception.html
platform/chromium/virtual/gpu/fast/canvas/webgl/data-view-test.html
Comment 3 Adam Barth 2013-01-22 09:42:50 PST
Comment on attachment 183946 [details]
Patch

This is great, but it looks like you're breaking some tests.
Comment 4 Kentaro Hara 2013-01-22 16:37:06 PST
(In reply to comment #0)
> Now there is no optional Isolate parameter in the code base (except for throwError()).

ah, throwError() is calling v8String()... so I need to remove the optional Isolate parameter of throwError() first.
Comment 5 Kentaro Hara 2013-01-23 00:30:43 PST
Comment on attachment 183946 [details]
Patch

Now it should be safe to commit it.
Comment 6 WebKit Review Bot 2013-01-23 00:47:00 PST
Comment on attachment 183946 [details]
Patch

Clearing flags on attachment: 183946

Committed r140521: <http://trac.webkit.org/changeset/140521>
Comment 7 WebKit Review Bot 2013-01-23 00:47:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Kentaro Hara 2013-01-23 05:17:31 PST
*** Bug 104239 has been marked as a duplicate of this bug. ***
Comment 9 Kentaro Hara 2013-01-23 05:17:42 PST
*** Bug 104236 has been marked as a duplicate of this bug. ***