RESOLVED DUPLICATE of bug 107540104239
[V8] Make an Isolate mandatory in v8String() 
https://bugs.webkit.org/show_bug.cgi?id=104239
Summary [V8] Make an Isolate mandatory in v8String()
Kentaro Hara
Reported 2012-12-06 01:46:52 PST
This will slightly speed up v8String().
Attachments
Patch (4.44 KB, patch)
2012-12-06 01:51 PST, Kentaro Hara 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-06 01:51:26 PST
Created attachment 177973 [details] Patch
Adam Barth
Comment 2 2012-12-06 08:42:14 PST
Comment on attachment 177973 [details] Patch LGTM, but this looks to be causing IDB crashes.
Kentaro Hara
Comment 3 2012-12-06 16:36:47 PST
SerializedScriptValue has methods like xxx(Isolate* isolate = 0), and the methods can pass 0 to v8Integer() or v8String(). We need to kill an optional isolate parameter first and guarantee that an isolate is not 0.
Kentaro Hara
Comment 4 2013-01-23 05:17:31 PST
*** This bug has been marked as a duplicate of bug 107540 ***
Note You need to log in before you can comment on or make changes to this bug.