Bug 104239 - [V8] Make an Isolate mandatory in v8String()
Summary: [V8] Make an Isolate mandatory in v8String()
Status: RESOLVED DUPLICATE of bug 107540
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 01:46 PST by Kentaro Hara
Modified: 2013-01-23 05:17 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2012-12-06 01:51 PST, Kentaro Hara 		abarth: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-12-06 01:46:52 PST 
This will slightly speed up v8String().
Comment 1 Kentaro Hara 2012-12-06 01:51:26 PST 
Created attachment 177973 [details]
Patch
Comment 2 Adam Barth 2012-12-06 08:42:14 PST 
Comment on attachment 177973 [details]
Patch

LGTM, but this looks to be causing IDB crashes.
Comment 3 Kentaro Hara 2012-12-06 16:36:47 PST 
SerializedScriptValue has methods like xxx(Isolate* isolate = 0), and the methods can pass 0 to v8Integer() or v8String(). We need to kill an optional isolate parameter first and guarantee that an isolate is not 0.
Comment 4 Kentaro Hara 2013-01-23 05:17:31 PST 

*** This bug has been marked as a duplicate of bug 107540 ***