RESOLVED DUPLICATE of bug 107540 104236
[V8] Make an Isolate mandatory in v8Integer() 
https://bugs.webkit.org/show_bug.cgi?id=104236
Summary [V8] Make an Isolate mandatory in v8Integer()
Kentaro Hara
Reported 2012-12-06 01:33:22 PST
This will slightly speed up v8Integer().
Attachments
Patch (2.34 KB, patch)
2012-12-06 01:36 PST, Kentaro Hara 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-12-06 01:36:19 PST
Created attachment 177971 [details] Patch
Adam Barth
Comment 2 2012-12-06 08:42:56 PST
Comment on attachment 177971 [details] Patch LGTM but this appears to be causing IDB crashes. Maybe those are in the tree already?
Kentaro Hara
Comment 3 2012-12-06 16:36:23 PST
(In reply to comment #2) > (From update of attachment 177971 [details]) > LGTM but this appears to be causing IDB crashes. Maybe those are in the tree already? Ah, SerializedScriptValue has methods like xxx(Isolate* isolate = 0), and the methods can pass 0 to v8Integer() or v8String(). We need to kill an optional isolate parameter first and guarantee that an isolate is not 0.
Kentaro Hara
Comment 4 2013-01-23 05:17:42 PST
*** This bug has been marked as a duplicate of bug 107540 ***
Note You need to log in before you can comment on or make changes to this bug.