Bug 107274 - Web Inspector: [Canvas] UI: add a context selector to show screenshot of any canvas in the log
Summary: Web Inspector: [Canvas] UI: add a context selector to show screenshot of any ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Adaikin
URL:
Keywords:
Depends on: 107019 107280
Blocks:
  Show dependency tree / graph
 
Reported: 2013-01-18 06:01 PST by Andrey Adaikin
Modified: 2013-01-18 09:07 PST (History)
8 users (show)

See Also:

Attachments
Patch (31.58 KB, patch)
2013-01-18 06:02 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (20.71 KB, patch)
2013-01-18 07:26 PST, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2013-01-18 07:41 PST, Andrey Adaikin 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2013-01-18 06:01:17 PST 
Adding a canvas context selector to display in the replay image screenshot.

Patch to follow.
Comment 1 Andrey Adaikin 2013-01-18 06:02:51 PST 
Created attachment 183436 [details]
Patch
Comment 2 Pavel Feldman 2013-01-18 06:05:11 PST 
Comment on attachment 183436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=183436&action=review

> Source/WebCore/ChangeLog:8
> +        Adding a canvas context selector to display in the replay image screenshot.

Please explain what changed and why. Too many changed for such a brief explanation. Is there a way to split this into backend and front-end changes?
Comment 3 Andrey Adaikin 2013-01-18 07:26:35 PST 
Created attachment 183450 [details]
Patch
Comment 4 Andrey Adaikin 2013-01-18 07:29:24 PST 
(In reply to comment #2)
> (From update of attachment 183436 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=183436&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Adding a canvas context selector to display in the replay image screenshot.
> 
> Please explain what changed and why. Too many changed for such a brief explanation. Is there a way to split this into backend and front-end changes?

Extracted backend changes to https://bugs.webkit.org/show_bug.cgi?id=107280
Comment 5 Andrey Adaikin 2013-01-18 07:41:47 PST 
Created attachment 183456 [details]
Patch
Comment 6 Andrey Adaikin 2013-01-18 09:07:02 PST 
Committed r140160: <http://trac.webkit.org/changeset/140160>