Bug 107019 – Web Inspector: [Canvas] introduce Resource.toDataURL

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Adaikin]

Resource.toDataURL will return string data url representation of a resource, if applicable. For example, for a rendering context resource (2D or WebGL) it will return canvas.toDataURL().

Patch to follow.

[Andrey Adaikin]

Created attachment 182992 [details]
Patch

[Pavel Feldman]

Comment on attachment 182992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182992&action=review

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2957
> -        if (!this._traceLogPlayer || this._traceLogPlayer.traceLog() !== traceLog) {

Why did this code go?

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2994
> -    _onTraceLogPlayerReset: function()

ditto

[Andrey Adaikin]

Comment on attachment 182992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182992&action=review

>> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2957
>> -        if (!this._traceLogPlayer || this._traceLogPlayer.traceLog() !== traceLog) {
> 
> Why did this code go?

Now these players are stored in the this._traceLogPlayers map, and we will support replaying all trace logs simultaneously (while before we kept only last player that was touched).
This change is needed because we will expose replayed resources state (like current screenshot of a canvas, and etc.), which are bound to a "replay world".

>> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:-2994
>> -    _onTraceLogPlayerReset: function()
> 
> ditto

This is not needed any more, everything is encapsulated in the Player.

[WebKit Review Bot]

Comment on attachment 182992 [details]
Patch

Clearing flags on attachment: 182992

Committed r140142: <http://trac.webkit.org/changeset/140142>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.