We need to expose replayable resource info and replay state via the protocol. The ResourceInfo describes a replayable resource, i.e. the info about a resource that was stored to replay it later. The ResourceState describes a current state of a resource being replayed on the back-end. Patch to follow.
Created attachment 183452 [details] Patch
Comment on attachment 183452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183452&action=review > Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:158 > +void InjectedScriptCanvasModule::resourceInfo(ErrorString* errorString, const String& resourceId, RefPtr<TypeBuilder::Canvas::ResourceInfo>* result) getResourceInfo (since you use output parameter). > Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:172 > +void InjectedScriptCanvasModule::resourceState(ErrorString* errorString, const String& traceLogId, const String& resourceId, RefPtr<TypeBuilder::Canvas::ResourceState>* result) ditto > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:2972 > + * @param {string} traceLogId CanvasAgent.TraceLogId > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:3011 > + return { I'd introduce a small wrapper that goes into runtime cast. > Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:3069 > + * @return {!Object} @return {{id:string,... > Source/WebCore/inspector/Inspector.json:3215 > + { "name": "dataURL", "type": "string", "optional": true, "description": "Screenshot data URL." } imageURL
Comment on attachment 183452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=183452&action=review >> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:2972 >> + * @param {string} traceLogId > > CanvasAgent.TraceLogId we'll need to modify generate_protocol_externs.py to also generate JSON typedef's for @constructors, like: /** @constructor */ CanvasAgent.TraceLog = function() { /** @type {CanvasAgent.TraceLogId} */ this.id; /** @type {Array.<CanvasAgent.Call>} */ this.calls; /** @type {number|undefined} */ this.startOffset; /** @type {boolean|undefined} */ this.alive; } /** @typedef {{id:CanvasAgent.TraceLogId, calls:Array.<CanvasAgent.Call>, ...}} */ CanvasAgent.TraceLogJSON; I'll do this in a separate patch: https://bugs.webkit.org/show_bug.cgi?id=107287
Committed r140157: <http://trac.webkit.org/changeset/140157>