[Chromium] Remove idbFactory from WebKitPlatformSupport
Created attachment 181924 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment on attachment 181924 [details] Patch Attachment 181924 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15771537
Looks like we need to wait for some Chromium changes to sync upstream first. Removing review flag until that happens.
Comment on attachment 181924 [details] Patch Attachment 181924 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15754787
You probably need to increase the chromium_rev in this file: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35 Usually we do that in a separate patch.
Created attachment 182052 [details] Patch
Comment on attachment 182052 [details] Patch Attachment 182052 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15775613
Comment on attachment 182052 [details] Patch Attachment 182052 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15775618
Created attachment 182228 [details] Patch
Comment on attachment 182228 [details] Patch Indeed it was a DEPS problem, and it appears that someone else has resolved it in the meantime. http://trac.webkit.org/changeset/139347/trunk/Source/WebKit/chromium/DEPS So, resubmitting same patch.
This appears to be crashing a truck load of storage tests on cr-linux bot.
Created attachment 186642 [details] Patch
Comment on attachment 186642 [details] Patch Clearing flags on attachment: 186642 Committed r141896: <http://trac.webkit.org/changeset/141896>
All reviewed patches have been landed. Closing bug.
Re-opened since this is blocked by bug 108956
Created attachment 189141 [details] Patch
Comment on attachment 189141 [details] Patch Same patch, applied to ToT. Now that https://codereview.chromium.org/12230054 has landed, this no longer crashes LayoutTests/http/tests/security/*indexeddb*
Comment on attachment 189141 [details] Patch Clearing flags on attachment: 189141 Committed r143382: <http://trac.webkit.org/changeset/143382>
Reverted r143382 for reason: Breaks Chromium win/mac canary compilation Committed r143403: <http://trac.webkit.org/changeset/143403>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/40413/steps/compile/logs/stdio In file included from ../../webkit/tools/test_shell/test_shell_mac.mm:41: ../../webkit/tools/test_shell/test_shell_webkit_init.h:76:34:error: 'idbFactory' marked 'override' but does not override any member functions virtual WebKit::WebIDBFactory* idbFactory() OVERRIDE;
We shouldn't ever use OVERRIDE when subclassing the WebKit API. It just leads to this sort of pain...
(In reply to comment #23) > We shouldn't ever use OVERRIDE when subclassing the WebKit API. It just leads to this sort of pain... I removed a bunch of them a few weeks ago, but this one was in test_shell and I missed it last time. Anyway, https://codereview.chromium.org/12320002/ will fix it then I'll re-submit this patch.
Comment on attachment 189141 [details] Patch Fixed downstream issue, roll led DEPS. Can we just resubmit this attachment or do I need to reupload the same patch again?
Comment on attachment 189141 [details] Patch We can just resubmit.
Comment on attachment 189141 [details] Patch Clearing flags on attachment: 189141 Committed r143473: <http://trac.webkit.org/changeset/143473>