Bug 107132 - [Chromium] Give webkit_support a chance to reset state between layout test runs
Summary: [Chromium] Give webkit_support a chance to reset state between layout test runs
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on: 107916
Blocks: 82948 106457
  Show dependency tree / graph
 
Reported: 2013-01-17 08:29 PST by Darin Fisher (:fishd, Google)
Modified: 2013-02-14 08:41 PST (History)
7 users (show)

See Also:

Attachments
v1 patch (1.50 KB, patch)
2013-01-17 08:34 PST, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2013-01-23 19:20 PST, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2013-01-17 08:29:39 PST 
[Chromium] Give webkit_support a chance to reset state between layout test runs

We currently only have need for this on OS(ANDROID), but now it would be useful
to have a hook for resetting state on all platforms.
Comment 1 Darin Fisher (:fishd, Google) 2013-01-17 08:30:44 PST 
Corresponding Chromium patch:
https://codereview.chromium.org/11946027/
Comment 2 Darin Fisher (:fishd, Google) 2013-01-17 08:34:12 PST 
Created attachment 183195 [details]
v1 patch

The Chromium side of this change needs to land first.
Comment 3 Darin Fisher (:fishd, Google) 2013-01-17 08:35:14 PST 
(And, I need to also do a DEPS roll.)
Comment 4 WebKit Review Bot 2013-01-17 08:36:36 PST 
Comment on attachment 183195 [details]
v1 patch

Attachment 183195 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15940134
Comment 5 Peter Beverloo (cr-android ews) 2013-01-17 08:41:40 PST 
Comment on attachment 183195 [details]
v1 patch

Attachment 183195 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15941066
Comment 6 Mark Pilgrim (Google) 2013-01-23 19:20:48 PST 
Created attachment 184382 [details]
Patch
Comment 7 Mark Pilgrim (Google) 2013-01-23 19:21:30 PST 
Comment on attachment 184382 [details]
Patch

Chromium patch has landed and DEPS have been rolled. Resubmitting identical patch against ToT.
Comment 8 WebKit Review Bot 2013-01-23 21:53:39 PST 
Comment on attachment 184382 [details]
Patch

Clearing flags on attachment: 184382

Committed r140653: <http://trac.webkit.org/changeset/140653>
Comment 9 WebKit Review Bot 2013-01-23 21:53:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Review Bot 2013-01-24 22:28:08 PST 
Re-opened since this is blocked by bug 107916
Comment 11 Mark Pilgrim (Google) 2013-02-14 08:41:55 PST 
Made unnecessary by taking a different approach in http://src.chromium.org/viewvc/chrome?view=rev&revision=181641